feat: replace Base64 usage with String#pack
#228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change here replaces the singular use of `Base64.strict_encode64`
with that method’s body, `["…"].pack("m0")`, pulled straight from the
Base64 gem’s source (linked below).
See-also: https://github.com/ruby/base64/blob/v0.3.0/lib/base64.rb#L282-L284
|
The Ruby 3.4 unit test failure is owing to this issue in the cloud_events gem: cloudevents/sdk-ruby#82 Also possibly the reason for the Ruby 3.4 conformance test, but the log output isn't as exact. The log output in the Setup Ruby step for the failed Ruby 3.4 conformance test is interesting:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change here replaces the singular use of
Base64.strict_encode64with that method’s body,["…"].pack("m0"), pulled straight from the Base64 gem’s source.Thanks for considering this change!