Skip to content

Conversation

averikitsch
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2018
@codecov
Copy link

codecov bot commented Jun 25, 2018

Codecov Report

Merging #676 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #676   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e55a6d1...89b8009. Read the comment docs.


test.before(tools.stubConsole);
test.after.always(tools.restoreConsole);
const {
Copy link
Contributor

@fhinkel fhinkel Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fit this in one line or is it too long? If it is too long, I think it should be written as

const {runAsync} = 
  require(...);

Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

created can be listed with `gcloud alpha tasks queues list`.

```
export QUEUE_ID=my-appengine-queue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? Further down we check for GCP_QUEUE

@fhinkel fhinkel added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2018
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 28, 2018
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 28, 2018
@averikitsch averikitsch merged commit 381b89a into master Jun 28, 2018
@averikitsch averikitsch deleted the gae-tasks branch June 28, 2018 19:37
ace-n pushed a commit that referenced this pull request Jun 29, 2018
* update license

* updated with client library

* passing tests

* update env var for QUEUE

* upgrade packages

* update license

* updated with client library

* passing tests

* update env var for QUEUE

* upgrade packages
ace-n pushed a commit that referenced this pull request Jun 29, 2018
* update license

* updated with client library

* passing tests

* update env var for QUEUE

* upgrade packages

* update license

* updated with client library

* passing tests

* update env var for QUEUE

* upgrade packages
ace-n pushed a commit that referenced this pull request Nov 17, 2022
* test: changes AutoML v1beta1 model for v1 model

* test: changed asserts
ace-n pushed a commit that referenced this pull request Nov 17, 2022
* test: changes AutoML v1beta1 model for v1 model

* test: changed asserts
ace-n pushed a commit that referenced this pull request Nov 17, 2022
* test: changes AutoML v1beta1 model for v1 model

* test: changed asserts
ace-n pushed a commit that referenced this pull request Nov 17, 2022
* test: changes AutoML v1beta1 model for v1 model

* test: changed asserts
ace-n pushed a commit that referenced this pull request Nov 17, 2022
* test: changes AutoML v1beta1 model for v1 model

* test: changed asserts
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
NimJay pushed a commit that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants