fixit: Update to Gen App Builder Tests #10092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
samples
holtskinner
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
holtskinner
changed the title
holtskinner
changed the title
holtskinner
added
the
kokoro:run
- `ListDocumentsPager` the return type for `client.list_documents` is not exposed as a type from the client library
kokoro-team
removed
the
kokoro:run
holtskinner
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
1 task
| @@ -44,5 +42,7 @@ def list_documents_sample( | |||
| for result in response: | |||
| print(result) | |||
|
|
|||
| return response | |||
There was a problem hiding this comment.
Consider returning a relevant object within the response that matches the name of the method. Is there a list that comes back as part of the response you can return?
There was a problem hiding this comment.
It's hard to get the results this way because it returns a Pager object.
I don't know if it's possible to put a type annotation for because it's not exposed as a type in the client library (but I could be wrong)
engelke
approved these changes
May 26, 2023
engelke
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10066
v1GA endpoint