Skip to content

docs(samples): Added answer_query_sample.py #12564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Conversation

holtskinner
Copy link
Contributor

@holtskinner holtskinner commented Sep 5, 2024

This code was written by Gemini ✨ as an experiment, then edited by me for accuracy.

@holtskinner holtskinner requested review from a team as code owners September 5, 2024 16:17
Copy link

snippet-bot bot commented Sep 5, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: discoveryengine Issues related to the Discovery Engine API API. labels Sep 5, 2024
Copy link
Member

@briandorsey briandorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Holt! OK to hold on this PR for a bit to sync on metadata/tagging?

@holtskinner holtskinner added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 6, 2024
@holtskinner holtskinner assigned briandorsey and unassigned gericdong Sep 6, 2024
@briandorsey briandorsey added generated: genai Contains Generative AI based code, requesting an additional reviewer. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Sep 19, 2024
@briandorsey briandorsey dismissed their stale review September 19, 2024 16:46

Was holding for a GenAI label and now we have it.

Added disclaimer about gemini generation
Copy link
Member

@briandorsey briandorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and approved from a Python samples and GenAI policy context. Not reviewed for this specific API usage.

(Not explicitly approving in GH terms only because GenAI code needs two reviews and the repo is configured to only require one review. Second reviewer should approve once reviewed.) Approving. I misread the policy around "trusted contributors".

@holtskinner holtskinner merged commit d84651b into main Sep 20, 2024
15 checks passed
@holtskinner holtskinner deleted the new-samples-branch branch September 20, 2024 16:28
riathakkar pushed a commit to riathakkar/python-docs-samples that referenced this pull request Oct 8, 2024
* docs(samples): Added answer_query_sample.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Fixed Sample to pass tests

* Fixed test engine

* Update answer_query_sample.py

Added disclaimer about gemini generation

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: discoveryengine Issues related to the Discovery Engine API API. generated: genai Contains Generative AI based code, requesting an additional reviewer. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants