Add documentation on command-line function to get client ID #5712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
google-cla
bot
added
the
cla: yes
dandhlee
requested changes
Apr 19, 2021
There was a problem hiding this comment.
Thanks for adding this in! Just a minor comment below.
Otherwise, I think it might be worth putting in a note saying that this is an alternate in case there's issues with the get_client_id.py module, otherwise I was confused with why there's two of them until I read the related issue. Passing it to @leahecole for further review from here!
|
Hey @leahecole - sorry to disturb, any update on this ? Does this change look okay to you ? |
leahecole
approved these changes
Apr 23, 2021
dandhlee
approved these changes
Apr 23, 2021
scouvreur
force-pushed
the
scouvrer-get-client-id
branch
from
56d9b7b to
b1b287a
Compare
|
@dandhlee @leahecole thanks for your comments ! I addressed the changes, feel free to merge whenever you can as I don't have permissions 🙂 |
leahecole
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
leahecole
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5546
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)