-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: VM Indentity samples added. #5884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
Hey! I'm so sorry for the delay on looking at this. Can you have a reviewer familiar with Compute products on your team take a look to make sure this is good from the product side? I'll take a look at the tests. |
@engelke I'd actually prefer if you could be the sample owner that takes a look at this just given that you have more experience in this area than I do 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@busunkim96 Could you have a look at this? :) |
Description
Fixes b/187880839
I made the tests to execute only when running on GCE VM instance (which I assume is happening for the automated tests). I think they are more valuable this way than if I'd use mock to provide responses from the metadata server. Then they wouldn't be able to fail at all IMO.
Checklist
nox -s py-3.6
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)