Skip to content

feat: VM Indentity samples added. #5884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 11, 2021
Merged

Conversation

m-strzelczyk
Copy link
Contributor

Description

Fixes b/187880839

I made the tests to execute only when running on GCE VM instance (which I assume is happening for the automated tests). I think they are more valuable this way than if I'd use mock to provide responses from the metadata server. Then they wouldn't be able to fail at all IMO.

Checklist

@m-strzelczyk m-strzelczyk requested a review from a team as a code owner May 25, 2021 07:44
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 25, 2021
@snippet-bot
Copy link

snippet-bot bot commented May 25, 2021

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@tmatsuo tmatsuo added the snippet-bot:force-run Force snippet-bot runs its logic label Jun 1, 2021
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jun 1, 2021
@leahecole
Copy link
Collaborator

Hey! I'm so sorry for the delay on looking at this. Can you have a reviewer familiar with Compute products on your team take a look to make sure this is good from the product side? I'll take a look at the tests.

@leahecole leahecole assigned engelke and unassigned leahecole Jun 4, 2021
@leahecole
Copy link
Collaborator

@engelke I'd actually prefer if you could be the sample owner that takes a look at this just given that you have more experience in this area than I do 😄

Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke requested a review from busunkim96 June 4, 2021 23:37
@m-strzelczyk
Copy link
Contributor Author

@busunkim96 Could you have a look at this? :)

@m-strzelczyk m-strzelczyk merged commit e5234a9 into master Jun 11, 2021
@m-strzelczyk m-strzelczyk deleted the compute_metadata_vm_identity branch June 11, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants