Skip to content

chore(dataflow): update conftest, make publisher subprocess a daemon #6475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 30, 2021
Merged

chore(dataflow): update conftest, make publisher subprocess a daemon #6475

merged 11 commits into from
Jul 30, 2021

Conversation

davidcavazos
Copy link
Contributor

@davidcavazos davidcavazos commented Jul 26, 2021 •
edited
Loading

Description

Fixes #6445, #6094

  • Update conftest to use the newer version in the GPU samples
  • Make the publisher subprocess a daemon so the main process doesn't wait indefinitely
  • Other small overall improvements in the conftest

ℹ️ The large diff of the conftest is because I'm replacing the parent conftest with the more updated one from the gpu-examples. I deliberately separated the conftest updates so I could fix these issues in a separate PR without triggering the flaky tests.

Checklist

@davidcavazos davidcavazos requested a review from a team as a code owner July 26, 2021 18:59
@product-auto-label product-auto-label bot added api: dataflow Issues related to the Dataflow API. samples Issues that are directly related to samples. labels Jul 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 26, 2021
@davidcavazos davidcavazos force-pushed the dataflow-fix-flaky-tests branch from af41d86 to 73073fb Compare July 26, 2021 19:05
@davidcavazos davidcavazos added the blunderbuss: assign Instruct blunderbuss to assign someone label Jul 27, 2021
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Jul 27, 2021
busunkim96
busunkim96 approved these changes Jul 28, 2021
View reviewed changes
@parthea parthea changed the title dataflow: update conftest, make publisher subprocess a daemon chore(dataflow): update conftest, make publisher subprocess a daemon Jul 30, 2021
@leahecole leahecole merged commit 6bba089 into GoogleCloudPlatform:master Jul 30, 2021
@davidcavazos davidcavazos deleted the dataflow-fix-flaky-tests branch July 30, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@leahecole leahecole

@busunkim96 busunkim96

Labels
api: dataflow Issues related to the Dataflow API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address Dataflow pytest fixtures issues
3 participants
@davidcavazos @leahecole @busunkim96