Skip to content

adding owlbot and notebook ci #7810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 34 commits into from
Closed

adding owlbot and notebook ci #7810

wants to merge 34 commits into from

Conversation

loferris
Copy link
Contributor

Description

Fixes #7809

Note: It's a good idea to open an issue first for discussion.

Checklist

  • Please merge this PR for me once it is approved.

@loferris loferris requested a review from a team as a code owner April 21, 2022 01:02
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 21, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 22, 2022
@loferris loferris requested a review from a team as a code owner April 22, 2022 00:51
Copy link
Collaborator

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check why owl bot is deleting .github/snippet-bot.yml

aggregateChecks: true
alwaysCreateStatusCheck: true
ignoreFiles:
- README.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file should be deleted.

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2022
@loferris loferris added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2022
Copy link
Collaborator

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header-check is failing with this message

.cloud-build/CheckPythonVersion.py should have a copyright year of 2022
.cloud-build/cleanup/cleanup-cloudbuild.yaml is missing a valid license header.
.cloud-build/cleanup/requirements.txt is missing a valid license header.
.cloud-build/execute_changed_notebooks_cli.py should have a copyright year of 2022
.cloud-build/execute_notebook_cli.py should have a copyright year of 2022
.cloud-build/execute_notebook_helper.py should have a copyright year of 2022
.cloud-build/execute_notebook_remote.py should have a copyright year of 2022
.cloud-build/notebook-execution-test-cloudbuild-single.yaml is missing a valid license header.
.cloud-build/notebook-execution-test-cloudbuild.yaml is missing a valid license header.
.cloud-build/requirements.txt is missing a valid license header.
.cloud-build/test_folders.txt is missing a valid license header.
.cloud-build/utils/__init__.py is missing a valid license header.
.github/workflows/ci.yaml is missing a valid license header.
.github/workflows/linter/requirements.txt is missing a valid license header.
.github/workflows/linter/run_linter.sh should have a copyright year of 2022

@parthea parthea assigned loferris and unassigned parthea May 4, 2022
@dandhlee
Copy link
Collaborator

Hey @loferris, friendly ping on this!

@loferris
Copy link
Contributor Author

loferris commented Feb 2, 2023

The header-check is failing with this message

.cloud-build/CheckPythonVersion.py should have a copyright year of 2022
.cloud-build/cleanup/cleanup-cloudbuild.yaml is missing a valid license header.
.cloud-build/cleanup/requirements.txt is missing a valid license header.
.cloud-build/execute_changed_notebooks_cli.py should have a copyright year of 2022
.cloud-build/execute_notebook_cli.py should have a copyright year of 2022
.cloud-build/execute_notebook_helper.py should have a copyright year of 2022
.cloud-build/execute_notebook_remote.py should have a copyright year of 2022
.cloud-build/notebook-execution-test-cloudbuild-single.yaml is missing a valid license header.
.cloud-build/notebook-execution-test-cloudbuild.yaml is missing a valid license header.
.cloud-build/requirements.txt is missing a valid license header.
.cloud-build/test_folders.txt is missing a valid license header.
.cloud-build/utils/__init__.py is missing a valid license header.
.github/workflows/ci.yaml is missing a valid license header.
.github/workflows/linter/requirements.txt is missing a valid license header.
.github/workflows/linter/run_linter.sh should have a copyright year of 2022

Cannot be fixed manually on this PR, as the headers are missing in the synthtool template, so owlbot overwrites.

@engelke engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2023
@kweinmeister
Copy link
Contributor

Closing this PR, as #10011 will supersede it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add notebook sample CI testing template from synthtool
6 participants