Skip to content

add retries for subnetwork not ready errors #9523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 10, 2023
Merged

add retries for subnetwork not ready errors #9523

merged 7 commits into from
Apr 10, 2023

Conversation

leahecole
Copy link
Collaborator

@leahecole leahecole commented Apr 7, 2023

Description

Fixes #9513
Fixes #9461
Fixes #9445

Even though I used the native retries in #9496, I went with backoff here because it was already in use in the sample. If you prefer i retrofit all of it to the native retry though, I can! I also think this will help with #9437

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@leahecole leahecole requested a review from a team as a code owner April 7, 2023 14:12
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: dataproc Issues related to the Dataproc API. labels Apr 7, 2023
@leahecole
Copy link
Collaborator Author

hmm, not sure why we're getting a not found. I'll look more into this later

@leahecole
Copy link
Collaborator Author

leahecole commented Apr 7, 2023

d'oh, it's the multiple decorators. I'll fix it
image

@leahecole leahecole marked this pull request as draft April 7, 2023 17:40
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 7, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 7, 2023
@leahecole leahecole marked this pull request as ready for review April 7, 2023 18:11
@leahecole leahecole added the snippet-bot:force-run Force snippet-bot runs its logic label Apr 7, 2023
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Apr 7, 2023
@leahecole leahecole added the blunderbuss: assign Instruct blunderbuss to assign someone label Apr 7, 2023
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Apr 7, 2023
@leahecole leahecole merged commit abeeaff into main Apr 10, 2023
@leahecole leahecole deleted the fix_9513 branch April 10, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dataproc Issues related to the Dataproc API. samples Issues that are directly related to samples.
Projects
None yet
7 participants