fix: Reorganizing fixtures for the dataproc quickstart #9666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
samples
snippet-bot
bot
removed
the
snippet-bot:force-run
snippet-bot
bot
removed
the
snippet-bot:force-run
snippet-bot
bot
removed
the
snippet-bot:force-run
engelke
approved these changes
Apr 17, 2023
kweinmeister
approved these changes
Apr 18, 2023
This was referenced Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9461
Reorganizing the test fixtures to use module-scoped fixtures, with each fixture component set-up and tear-down having separate flaky-addressing backoff decorators. Also moving all tear-down logic into finally clauses.
Might still require additional refinement, if the backoffs are not catching the right exceptions.