Skip to content

fix: Add genappbuilder to CODEOWNERS #9866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 4, 2023
Merged

fix: Add genappbuilder to CODEOWNERS #9866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8cc92ba
Add genappbuilder to CODEOWNERS
holtskinner May 2, 2023
afebcfe
Restructure directory to match other client libraries.
holtskinner May 2, 2023
a9b0edd
Merge branch 'main' into genapp-fix
holtskinner May 2, 2023
ec544db
Merge branch 'main' into genapp-fix
holtskinner May 3, 2023
30916d1
Merge branch 'main' into genapp-fix
holtskinner May 3, 2023
294a4d9
Update discovery engine client library
holtskinner May 4, 2023
b1d5842
Merge branch 'main' into genapp-fix
holtskinner May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
/dataproc/**/* @GoogleCloudPlatform/dee-data-ai @GoogleCloudPlatform/python-samples-reviewers
/dialogflow/**/* @GoogleCloudPlatform/dee-data-ai @GoogleCloudPlatform/python-samples-reviewers
/dialogflow-cx/**/* @GoogleCloudPlatform/dee-data-ai @GoogleCloudPlatform/python-samples-reviewers
/discoveryengine/**/* @GoogleCloudPlatform/dee-data-ai @GoogleCloudPlatform/python-samples-reviewers
/documentai/**/* @GoogleCloudPlatform/dee-data-ai @GoogleCloudPlatform/python-samples-reviewers
/enterpriseknowledgegraph/**/* @GoogleCloudPlatform/dee-data-ai @GoogleCloudPlatform/python-samples-reviewers
/jobs/**/* @GoogleCloudPlatform/dee-data-ai @GoogleCloudPlatform/python-samples-reviewers
Expand Down
1 change: 1 addition & 0 deletions .github/auto-label.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ path:
dataproc: "dataproc"
datastore: "datastore"
dialogflow: "dialogflow"
discoveryengine: "discoveryengine"
dlp: "dlp"
dns: "dns"
documentai: "documentai"
Expand Down
2 changes: 1 addition & 1 deletion .github/blunderbuss.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ assign_prs_by:
- "api: dataproc"
- "api: dialogflow"
- "api: enterpriseknowledgegraph"
- "api: discoveryengine"
- "api: language"
- "api: ml"
- "api: notebooks"
Expand Down Expand Up @@ -298,4 +299,3 @@ assign_prs:
###
# Updates should be made to both assign_issues_by & assign_prs_by sections
###

0 genappbuilder/__init__.py → discoveryengine/__init__.py
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions genappbuilder/documents_sample_test.py → discoveryengine/documents_sample_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@

import os

from genappbuilder import import_documents_sample
from genappbuilder import list_documents_sample
from discoveryengine import import_documents_sample
from discoveryengine import list_documents_sample

project_id = os.environ["GOOGLE_CLOUD_PROJECT"]
location = "global"
Expand Down
0 genappbuilder/get_operation_sample.py → discoveryengine/get_operation_sample.py
View file
Open in desktop
File renamed without changes.
0 genappbuilder/import_documents_sample.py → discoveryengine/import_documents_sample.py
View file
Open in desktop
File renamed without changes.
0 genappbuilder/list_documents_sample.py → discoveryengine/list_documents_sample.py
View file
Open in desktop
File renamed without changes.
0 genappbuilder/list_operations_sample.py → discoveryengine/list_operations_sample.py
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions genappbuilder/operations_sample_test.py → discoveryengine/operations_sample_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@

import os

from genappbuilder import get_operation_sample
from genappbuilder import list_operations_sample
from genappbuilder import poll_operation_sample
from discoveryengine import get_operation_sample
from discoveryengine import list_operations_sample
from discoveryengine import poll_operation_sample

from google.api_core.exceptions import NotFound

Expand Down
0 genappbuilder/poll_operation_sample.py → discoveryengine/poll_operation_sample.py
View file
Open in desktop
File renamed without changes.
0 genappbuilder/requirements-test.txt → discoveryengine/requirements-test.txt
View file
Open in desktop
File renamed without changes.
2 changes: 2 additions & 0 deletions discoveryengine/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
google-cloud-discoveryengine==0.6.0
google-api-core==2.11.0
0 genappbuilder/search_sample.py → discoveryengine/search_sample.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion genappbuilder/search_sample_test.py → discoveryengine/search_sample_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

import os

from genappbuilder import search_sample
from discoveryengine import search_sample

project_id = os.environ["GOOGLE_CLOUD_PROJECT"]
location = "global"
Expand Down
2 changes: 0 additions & 2 deletions genappbuilder/requirements.txt
View file
Open in desktop

This file was deleted.