Skip to content

fix: update demosite to reflect error messages in client #9867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 3, 2023
Merged

fix: update demosite to reflect error messages in client #9867

merged 13 commits into from
May 3, 2023

Conversation

Sita04
Copy link
Collaborator

@Sita04 Sita04 commented May 2, 2023

  1. Update returned response from backend to include reason for "bad" actions.
  2. Update client messaging to display the bad action messages.
  3. Update client response to fetch 'Invalid token' value based on the reason returned.

@Sita04 Sita04 requested review from a team as code owners May 2, 2023 17:11
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: recaptchaenterprise Issues related to the reCAPTCHA API. asset: flagship DEE Asset tagging - Flagship. labels May 2, 2023
faube
faube reviewed May 3, 2023
View reviewed changes
faube
faube reviewed May 3, 2023
View reviewed changes
recaptcha_enterprise/demosite/app/static/global-e680a49614fd8ff8.js Outdated
const demoElement = document.querySelector("recaptcha-demo");
demoElement.setAttribute("score", score?.data?.score);
demoElement.setAttribute("verdict", score?.data?.verdict);
demoElement.setAttribute("verdict", score?.data?.label);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better to rename "verdict" to "label" here and elsewhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, was hesitant because I didn't know how Rhy set it up. But I've tried to update the label.
Will ask Rhy for a review.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morewry Could you PTAL at this change?

faube
faube reviewed May 3, 2023
View reviewed changes
@Sita04 Sita04 requested a review from faube May 3, 2023 14:55
faube
faube reviewed May 3, 2023
View reviewed changes
@engelke engelke merged commit 7c9b968 into main May 3, 2023
@engelke engelke deleted the demosite-client-error-msg branch May 3, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

@faube faube faube approved these changes

@HansEngebretsen HansEngebretsen Awaiting requested review from HansEngebretsen

@morewry morewry Awaiting requested review from morewry

Assignees

@m-strzelczyk m-strzelczyk

Labels
api: recaptchaenterprise Issues related to the reCAPTCHA API. asset: flagship DEE Asset tagging - Flagship. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sita04 @engelke @faube @m-strzelczyk