Skip to content

dataflow: update dataflow flags #9887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2023
Merged

dataflow: update dataflow flags #9887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ca326e
dataflow: launch job from same python version
davidcavazos May 3, 2023
cb752b9
update dataflow flags
davidcavazos May 3, 2023
13a8dab
Merge branch 'main' into dataflow
nicain May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion people-and-planet-ai/timeseries-classification/create_datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,12 @@ def run(
]
).sort_values(by="start_time")

beam_options = PipelineOptions(flags=[], **beam_args)
beam_options = PipelineOptions(
flags=[],
save_main_session=True,
requirements_file="requirements.txt",
**beam_args,
)
pipeline = beam.Pipeline(options=beam_options)

training_data, evaluation_data = (
Expand Down
3 changes: 0 additions & 3 deletions people-and-planet-ai/timeseries-classification/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,9 @@ def run_create_datasets() -> dict:
runner_params = {
"runner": "DataflowRunner",
"job_name": f"global-fishing-watch-create-datasets-{datetime.now().strftime('%Y%m%d-%H%M%S')}",
"save_main_session": args.get("save_main_session", True),
"sdk_container_image": args.get("container_image", CONTAINER_IMAGE),
"project": args.get("project", PROJECT),
"region": args.get("region", REGION),
"temp_location": args.get("temp_location", TEMP_DIR),
"experiments": ["use_runner_v2"],
}
params = {
"raw_data_dir": args.get("raw_data_dir", RAW_DATA_DIR),
Expand Down
4 changes: 2 additions & 2 deletions people-and-planet-ai/timeseries-classification/noxfile_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@

TEST_CONFIG_OVERRIDE = {
# You can opt out from the test for specific Python versions.
# > ℹ️ Test only on Python 3.9.
# > ℹ️ Test only on Python 3.10.
# > The Python version used is defined by the Dockerfile, so it's redundant
# > to run multiple tests since they would all be running the same Dockerfile.
"ignored_versions": ["2.7", "3.6", "3.7", "3.8", "3.10", "3.11"],
"ignored_versions": ["2.7", "3.6", "3.7", "3.8", "3.9", "3.11"],
# Old samples are opted out of enforcing Python type hints
# All new samples should feature them
"enforce_type_hints": True,
Expand Down