This repository was archived by the owner on Mar 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 236
Change default differ from apt to file #227
Labels
Comments
The reason we didn't do file by default is that the output can be huge. Not sure what the best approach is. |
I would be fine removing the default in favor of making the user specify at least one diff type. I agree with @aaron-prindle that defaulting to apt can be confusing but we definitely don't want to default to file, especially for the |
#256 has been merged. What do you think about making it the default? This is what it would look like:
|
@peter-evans I think it's probably fine, I don't think there's any "right" answer here :) would you like to open a PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently container-diff defaults to the apt differ, I think that this is confusing for users as running
container-diff diff <image-1> <image-2>
will say that there is no difference in the images (referring to no different apt-packages) when in fact files might be different and it isn't obvious that the default is apt for new users.The text was updated successfully, but these errors were encountered: