Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

Fix RPM differ to to include release of version #315

Merged

Conversation

hitthatrowdyy
Copy link
Contributor

Based off #297

We encountered the same problem where the result of no difference was false.

e.g.

08:01:25  Step 3/3 : RUN yum update --disableplugin=fastestmirror -y  && yum install --disableplugin=fastestmirror -y       unzip       epel-release       python       postgresql  && yum clean all && rm -rf /var/cache/yum
08:01:25   ---> Running in 51e7438d08e4
08:01:25  Loaded plugins: ovl
08:01:32  Resolving Dependencies
08:01:32  --> Running transaction check
08:01:32  ---> Package bind-license.noarch 32:9.9.4-74.el7_6.1 will be updated
08:01:32  ---> Package bind-license.noarch 32:9.9.4-74.el7_6.2 will be an update
08:01:32  ---> Package curl.x86_64 0:7.29.0-51.el7 will be updated
08:01:32  ---> Package curl.x86_64 0:7.29.0-51.el7_6.3 will be an update
08:01:32  ---> Package libcurl.x86_64 0:7.29.0-51.el7 will be updated
08:01:32  ---> Package libcurl.x86_64 0:7.29.0-51.el7_6.3 will be an update
08:01:32  ---> Package libssh2.x86_64 0:1.4.3-12.el7_6.2 will be updated
08:01:32  ---> Package libssh2.x86_64 0:1.4.3-12.el7_6.3 will be an update
08:01:32  ---> Package systemd.x86_64 0:219-62.el7_6.7 will be updated
08:01:32  ---> Package systemd.x86_64 0:219-62.el7_6.9 will be an update
08:01:32  ---> Package systemd-libs.x86_64 0:219-62.el7_6.7 will be updated
08:01:32  ---> Package systemd-libs.x86_64 0:219-62.el7_6.9 will be an update
08:01:32  --> Finished Dependency Resolution
08:01:32  
08:01:32  Dependencies Resolved
08:01:32  
08:01:32  ================================================================================
08:01:32   Package            Arch         Version                    Repository     Size
08:01:32  ================================================================================
08:01:32  Updating:
08:01:32   bind-license       noarch       32:9.9.4-74.el7_6.2        updates        87 k
08:01:32   curl               x86_64       7.29.0-51.el7_6.3          updates       269 k
08:01:32   libcurl            x86_64       7.29.0-51.el7_6.3          updates       222 k
08:01:32   libssh2            x86_64       1.4.3-12.el7_6.3           updates       135 k
08:01:32   systemd            x86_64       219-62.el7_6.9             updates       5.1 M
08:01:32   systemd-libs       x86_64       219-62.el7_6.9             updates       408 k
08:01:32  
08:01:32  Transaction Summary
08:01:32  ================================================================================
08:01:32  Upgrade  6 Packages
08:01:32  
08:01:32  Total download size: 6.1 M
08:01:32  Downloading packages:
08:01:32  Delta RPMs disabled because /usr/bin/applydeltarpm not installed.
08:01:32  --------------------------------------------------------------------------------
08:01:32  Total                                               39 MB/s | 6.1 MB  00:00     
08:01:32  Running transaction check
08:01:32  Running transaction test
08:01:32  Transaction test succeeded
08:01:32  Running transaction
08:01:33    Updating   : systemd-libs-219-62.el7_6.9.x86_64                          1/12 
08:01:35    Updating   : libssh2-1.4.3-12.el7_6.3.x86_64                             2/12 
08:01:36    Updating   : libcurl-7.29.0-51.el7_6.3.x86_64                            3/12 
08:01:38    Updating   : curl-7.29.0-51.el7_6.3.x86_64                               4/12 
08:01:40    Updating   : systemd-219-62.el7_6.9.x86_64                               5/12 
08:01:40  Failed to get D-Bus connection: Operation not permitted
08:01:40    Updating   : 32:bind-license-9.9.4-74.el7_6.2.noarch                     6/12 
08:01:42    Cleanup    : 32:bind-license-9.9.4-74.el7_6.1.noarch                     7/12 
08:01:43    Cleanup    : systemd-219-62.el7_6.7.x86_64                               8/12 
08:01:43    Cleanup    : curl-7.29.0-51.el7.x86_64                                   9/12 
08:01:45    Cleanup    : libcurl-7.29.0-51.el7.x86_64                               10/12 
08:01:47    Cleanup    : libssh2-1.4.3-12.el7_6.2.x86_64                            11/12 
08:01:50    Cleanup    : systemd-libs-219-62.el7_6.7.x86_64                         12/12 
08:01:50    Verifying  : 32:bind-license-9.9.4-74.el7_6.2.noarch                     1/12 
08:01:50    Verifying  : libssh2-1.4.3-12.el7_6.3.x86_64                             2/12 
08:01:50    Verifying  : curl-7.29.0-51.el7_6.3.x86_64                               3/12 
08:01:50    Verifying  : systemd-219-62.el7_6.9.x86_64                               4/12 
08:01:50    Verifying  : libcurl-7.29.0-51.el7_6.3.x86_64                            5/12 
08:01:50    Verifying  : systemd-libs-219-62.el7_6.9.x86_64                          6/12 
08:01:50    Verifying  : systemd-libs-219-62.el7_6.7.x86_64                          7/12 
08:01:50    Verifying  : libssh2-1.4.3-12.el7_6.2.x86_64                             8/12 
08:01:50    Verifying  : curl-7.29.0-51.el7.x86_64                                   9/12 
08:01:50    Verifying  : systemd-219-62.el7_6.7.x86_64                              10/12 
08:01:50    Verifying  : libcurl-7.29.0-51.el7.x86_64                               11/12 
08:01:50    Verifying  : 32:bind-license-9.9.4-74.el7_6.1.noarch                    12/12 
08:01:50  
08:01:50  Updated:
08:01:50    bind-license.noarch 32:9.9.4-74.el7_6.2  curl.x86_64 0:7.29.0-51.el7_6.3      
08:01:50    libcurl.x86_64 0:7.29.0-51.el7_6.3       libssh2.x86_64 0:1.4.3-12.el7_6.3    
08:01:50    systemd.x86_64 0:219-62.el7_6.9          systemd-libs.x86_64 0:219-62.el7_6.9 
08:01:50  
08:01:50  Complete!
08:01:50  Loaded plugins: ovl
08:01:50  Package unzip-6.0-19.el7.x86_64 already installed and latest version
08:01:50  Package epel-release-7-11.noarch already installed and latest version
08:01:50  Package python-2.7.5-80.el7_6.x86_64 already installed and latest version
08:01:50  Package postgresql-9.2.24-1.el7_5.x86_64 already installed and latest version
08:01:50  Nothing to do
08:01:50  Loaded plugins: fastestmirror, ovl
08:01:50  Cleaning repos: base epel extras updates
08:01:51  Removing intermediate container 51e7438d08e4
08:01:51   ---> 86f517e9df73
08:01:51  Successfully built 86f517e9df73

Then ...

08:01:52  + /home/ec2-user/bin/container-diff diff daemon://################ daemon://%%%%%%%%%%%%%%%%% --type=rpm
[Pipeline] echo
08:02:12  -----RPM-----
08:02:12  
08:02:12  Packages found only in ################ : None
08:02:12  
08:02:12  Packages found only in %%%%%%%%%%%%%%%%%: None
08:02:12  
08:02:12  Version differences: None

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@donmccasland donmccasland self-requested a review August 2, 2019 16:04
@donmccasland
Copy link
Member

Hey there. Thank you for this! If you can go through the CLA signing process, we can take change into the project.

@hitthatrowdyy
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@hitthatrowdyy
Copy link
Contributor Author

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@donmccasland donmccasland merged commit 97b57b4 into GoogleContainerTools:master Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants