-
Notifications
You must be signed in to change notification settings - Fork 419
feat: support select session_user;
#5313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit is part of support DBeaver that support function select session_user like postgres did. Signed-off-by: yihong0618 <[email protected]>
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Signed-off-by: yihong0618 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5313 +/- ##
==========================================
- Coverage 84.16% 83.87% -0.30%
==========================================
Files 1200 1202 +2
Lines 225386 226040 +654
==========================================
- Hits 189698 189590 -108
- Misses 35688 36450 +762 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Can we add a test case for this? It can be a sqlness test.
By the way, why it fails when we call select session_user()
@yihong0618 That's very helpful. Bookmarked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM. Please add a sqlness test just like https://github.com/GreptimeTeam/greptimedb/blob/main/tests/cases/standalone/common/system/pg_catalog.sql
You can run the sqlness tests via cargo sqlness -t <file_name>
Signed-off-by: yihong0618 <[email protected]>
Done~ and found <file_name> is not file_name is regex.... |
@yihong0618 Thank you! |
* feat: support `select session_user;` This commit is part of support DBeaver that support function select session_user like postgres did. Signed-off-by: yihong0618 <[email protected]> * fix: lint problem Signed-off-by: yihong0618 <[email protected]> * fix: address comments add tests Signed-off-by: yihong0618 <[email protected]> --------- Signed-off-by: yihong0618 <[email protected]>
This commit is part of support DBeaver that support function select session_user like postgres did.
first part of #5271 (comment)
will support
select pg_catalog.pg_database;
in next patchscreen shot;

I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
PR Checklist
Please convert it to a draft if some of the following conditions are not met.