Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

hpcviewer error with CCT filter #187

Closed
jmellorcrummey opened this issue Mar 24, 2022 · 2 comments
Closed

hpcviewer error with CCT filter #187

jmellorcrummey opened this issue Mar 24, 2022 · 2 comments
Labels
bug Something isn't working resolved Resolved, but need to be tested and confirmed

Comments

@jmellorcrummey
Copy link
Member

I created a filter for Intel GPUs. The filter suppresses nodes with "cl::sycl::detail*". I quit hpcviewer, which saves the filter for later use.

I reopened the same database. I get two pop ups.

First:

image

After clicking OK on the first, a second pop-up indicating an error appears:

image

The error file says the following:


(hpcviewer:67442): Gtk-WARNING **: 15:49:27.385: Negative content width -1 (allocation 1, extents 1x1) while allocating gadget (node scroll
edwindow, owner GtkScrolledWindow)

(hpcviewer:67442): Gtk-WARNING **: 15:49:29.069: Negative content width -1 (allocation 1, extents 1x1) while allocating gadget (node scroll
edwindow, owner GtkScrolledWindow)

** (hpcviewer:67442): CRITICAL **: 15:49:29.249: JNI class pointer is NULL for class org/eclipse/swt/accessibility/AccessibleObject

** (hpcviewer:67442): CRITICAL **: 15:49:29.249: JNI class pointer is NULL for class org/eclipse/swt/accessibility/AccessibleObject

If I close that pop up, I can then open the same database properly from the file menu. It still gives the first pop up, but the error disappears.

I can provide a database on JLSE. You can add the filter and see the problem.

I would like to see two changes.

  1. It is fine to flash the warning about CCT nodes elided, but it should be a pop-up that disappears without an active click. (enhancement request)
  2. the error should not happen (bug report)
@jmellorcrummey jmellorcrummey added the bug Something isn't working label Mar 24, 2022
@laksono
Copy link
Member

laksono commented Mar 24, 2022

  • Sometimes I saw the second error message "no active window" if I use TWM. It never happens when using Mac, and very rare when using GNOME WM.

  • The error message in hpcviewer.err is different. It's due to Eclipse's issue on GTK. I saw in Eclipse platform mailing list, this only happens with some older GTK and doesn't happen with the latest GTK.

  • Concerning the warning text, we can perhaps display it a message on top of the table so that we don't need to click the Ok button.

@laksono laksono added this to the Release 2022.03 milestone Mar 24, 2022
@laksono laksono removed this from the Release 2022.03 milestone Mar 31, 2022
laksono added a commit that referenced this issue Jun 3, 2022

Verified

This commit was signed with the committer’s verified signature.
Michael-F-Bryan Michael Bryan
Use a toggle check box if the user doesn't want to show the warning next
time or not.
If he/she checks the toggle, the warning won't be shown on a window
(message box) but instead on a view's message which doesn't require
people to click the annoying ok button.
@laksono laksono added this to the Release 2022.06 milestone Jun 6, 2022
@laksono laksono added the resolved Resolved, but need to be tested and confirmed label Jun 6, 2022
@laksono
Copy link
Member

laksono commented Jun 6, 2022

The fix is by adding an option whether the user wants to disable the warning window or not.
If the user doesn't want the warning window, no more window appears. Instead, the viewer shows the message on the table (and the user doesn't need to click any button)

image

@laksono laksono closed this as completed Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working resolved Resolved, but need to be tested and confirmed
Projects
None yet
Development

No branches or pull requests

2 participants