This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Merge from master RC1 to feature-prof2 branch #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix is to check the Java's "file.encoding" system property. If the property is based on ANSI character set, it's likely it doesn't support UTF. This assumption is not entirely correct, but good enough for now.
It seems it doesn't change to call once or twice. If once is sufficient, avoid overcomplexity by calling refresh twice. Minor update: add some comments
According to https://sandor.tech/java/2017/08/02/securerandom-can-hang.html the java.util.SecureRandom class may hang on Linux platforms. It's better to use the standard Random instead to avoid hang. It's just a test, it doesn't matter if it isn't do randomization properly.
prof2 database can have different types of id-tuple types (mpi, thread, cores, gpu contexts, streams ...). It doesn't make sense to linearize them to show the range range. We need to come up with a better solution. At the moment, removing the label is a better option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains fixes for: