Avoid resolving view when retrieving the previous compiler #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xel1045
force-pushed
the
fix-view-resolving
branch
from
d44f70a to
a800274
Compare
|
The same environments seems to be broken on the master branch: https://travis-ci.org/github/HTMLMin/Laravel-HTMLMin/builds/773310940 |
This was referenced Jan 3, 2022
|
@srmklive: can we get this merged too? After a rebase, the tests should pass. |
|
Merged. |
|
hi @srmklive are you planning to release a new version with this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When registering
htmlmin.compiler, theviewclass is resolved which is not supposed to happen in theregister. This behaviour may breaks other plugins that exceptviewto be registered later.This PR use the
callAfterResolvingto retrieve the old compiler whenviewis resolved.