Test on laravel 5.5 #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srmklive
force-pushed
the
laravel-55-tests
branch
from
c1752ca to
f1b88e1
Compare
GrahamCampbell
commented
Aug 24, 2017
| "graham-campbell/testbench": "^3.1|^4.0", | ||
| "mockery/mockery": "^0.9.4", | ||
| "phpunit/phpunit": "^4.8|^5.0" | ||
| "phpunit/phpunit": "^4.8|^5.0|^6.0" |
There was a problem hiding this comment.
Don't pull in phpunit 6. It won't work.
There was a problem hiding this comment.
If i pull in phpunit 6, the tests only fail on hhvm for Laravel 5.5. Do we need to support hhvm for 5.5?
There was a problem hiding this comment.
Do we need to support hhvm for 5.5?
I'd say no. :)
srmklive
force-pushed
the
laravel-55-tests
branch
6 times, most recently
from
e6261a7 to
9765781
Compare
srmklive
force-pushed
the
laravel-55-tests
branch
from
9765781 to
c014c4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.