ALB Service #1
Merged
ALB Service #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is being reviewed up stream - leaving it open here as a reminder in our pipeline. Please don't merge it. |
|
Merging this now, upstream is taking too long. Will maintain fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
segmentio#101 attempts to integrate ALB so that realtime socket connections can be load balanced, as ELB does not support this, however it seems it was rejected due to the implementation.
this PR attempts to re-introduce this ALB logic in a non breaking way by adding a different type of service that can be expicitly chosen as an alternative to the elb enabled web-service
tasks