Update W2-lesson-plan.md #239
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Update is based on HackYourFuture#238
isaachinman
requested changes
Oct 12, 2018
| @@ -9,12 +9,21 @@ | |||
| - Lifecycle methods are used when render is not enough on its own | |||
|
|
|||
| - Cover each, giving examples of when they might be useful | |||
| - componentWillMount: SSR | |||
| - constructor: initializing state | |||
There was a problem hiding this comment.
A constructor is not a lifecycle method. It shouldn't be included here, it will confuse students. As you know, constructors are pure JS.
I believe it's specifically mentioned elsewhere in the curriculum I wrote that state can be initialised in two ways:
- Class properties, eg:
state = { myThing: true}` inside the class directly - The
constructor, as you say here.
Generally class properties can be used for simple initialisation. Facebook uses class properties in their internal source code - it's not something controversial like decorators.
A constructor can be used to initialise state when you need more complicated logic (checking other data stores, cookies, localStorage, etc).
| - Cover how the lifecycle methods invoking order by react component in [this lifecycle diagram](http://projects.wojtekmaj.pl/react-lifecycle-methods-diagram/) the docs mentioned to. | ||
|
|
||
|
|
||
| **Can the answer on these questions possible?** |
There was a problem hiding this comment.
Change to: "Can we answer these questions?"
|
|
||
|
|
||
| **Can the answer on these questions possible?** | ||
| - in which of these lifecycle methods is it OK to call setState? (watch out for stack overflows) |
|
|
||
| **Can the answer on these questions possible?** | ||
| - in which of these lifecycle methods is it OK to call setState? (watch out for stack overflows) | ||
| - what methods are invoked on each component lifecycle: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Update is based on #238
Needs a review in order of a parts are not possible to cover, and spell/grammar checking.