go 1.16

[circa10a]

Created with brew bump-formula-pr.

resource blocks may require updates.

[SMillerDev]

I'd say we should bootstrap with a stable version. The only reason it was a beta before is because that was the only possible option.

[jessjenkins]

If the [email protected] alias has been renamed to [email protected] should there now be a [email protected] formula instead to replace it? (Just like there's a 1.14 formula)

[carlocab]

If the [email protected] alias has been renamed to [email protected] should there now be a [email protected] formula instead to replace it? (Just like there's a 1.14 formula)

Not necessarily.

However, if go1.15 satisfies the requirements for versioned formulae, it may be possible to add one. That said, we usually only maintain five versions of a formula at a time, and at the moment there are six seven go formulae. We'd need to remove two three before adding another one.

[poffe]

Looks like we need to wait until https://go.googlesource.com/tools.git/+refs gets a 1.16 tag

Two questions on this.

1. Why is godoc considered being a core part of the homebrew Formula?
2. If godoc really is needed maybe the other "official" way of installing it could be an option? I'm thinking of go get -u golang.org/x/tools/... or even go get -u golang.org/x/tools/godoc.

And thanks for the awesome work your doing maintaining this!

[SMillerDev]

Why is godoc considered being a core part of the homebrew Formula?

It's part of the official install instructions.
https://golang.org/doc/install/source#tools

If godoc really is needed maybe the other "official" way of installing it could be an option? I'm thinking of go get -u golang.org/x/tools/... or even go get -u golang.org/x/tools/godoc.

If you can find a way for that to download a checksummed dependency so we can be sure of the version and origin of it I think that would be a good change to make.

[dmitshur]

If godoc really is needed maybe the other "official" way of installing it could be an option? I'm thinking of go get -u golang.org/x/tools/... or even go get -u golang.org/x/tools/godoc.

If you can find a way for that to download a checksummed dependency so we can be sure of the version and origin of it I think that would be a good change to make.

Consider using go install golang.org/x/tools/cmd/godoc@latest or some fixed version instead of latest. This is possible as of Go 1.16 (see third paragraph here). If a fixed version is specified, then the result should be completely reproducible.

Edit: Fixed typo; this comment was meant to be about the new go install feature.

[SMillerDev]

That doesn't pin the checksum though so it's still vulnerable to various security issues.

[poffe]

It's part of the official install instructions.
https://golang.org/doc/install/source#tools

Well that very much depends on how one interpret "Install additional tools". For me, "additional" means something optional. I would be fine if this Formula came without godoc. But that might be just me, or?

[lonre]

It's part of the official install instructions.
https://golang.org/doc/install/source#tools

Well that very much depends on how one interpret "Install additional tools". For me, "additional" means something optional. I would be fine if this Formula came without godoc. But that might be just me, or?

It is also optional for me.

And also there is no godoc in the archive package, https://golang.org/dl/go1.16.darwin-amd64.tar.gz

[peterbourgon]

godoc is one of many supplementary tools in x/tools, none of which should be part of the formula.

[FiloSottile]

Generally, I tend to agree that godoc could be dropped from the formula. It's probably in there because it used to be shipped with Go releases, and we have docs on the installation page for that reason.

Maybe the caveats can direct the user to go install golang.org/x/tools/cmd/godoc@latest which as of Go 1.16 works without affecting the local module.

[carlocab]

On ARM:

Error: 180 failed steps!

Error: 180 failed steps!
brew install --build-from-source aerc
brew install --build-from-source ahoy
brew install --build-from-source --only-dependencies akamai
brew install --build-from-source akamai
brew install --build-from-source amazon-ecs-cli
brew install --build-from-source apache-brooklyn-cli
brew install --build-from-source aptly
brew install --build-from-source arduino-cli
brew install --build-from-source argo
brew install --build-from-source assh
brew install --build-from-source auditbeat
brew test --retry --verbose awsweeper
brew test --retry --verbose bazelisk
brew install --build-from-source --only-dependencies bettercap
brew install --build-from-source bettercap
brew install --build-from-source bitrise
brew install --build-from-source buildifier
brew install --build-from-source buildozer
brew install --build-from-source caddy
brew install --build-from-source carina
brew install --build-from-source cartridge-cli
brew install --build-from-source ccat
brew install --build-from-source cf-tool
brew install --build-from-source charm
brew install --build-from-source --only-dependencies charm-tools
brew install --build-from-source charm-tools
brew test --retry --verbose chart-testing
brew install --build-from-source circleci
brew install --build-from-source --only-dependencies clair
brew install --build-from-source clair
brew test --retry --verbose cloudformation-cli
brew install --build-from-source --only-dependencies collector-sidecar
brew install --build-from-source collector-sidecar
brew install --build-from-source confd
brew test --retry --verbose conjure-up
brew install --build-from-source consul
brew test --retry --verbose container-structure-test
brew test --retry --verbose container-structure-test
brew install --build-from-source cql
brew install --build-from-source --only-dependencies cwlogs
brew install --build-from-source cwlogs
brew test --retry --verbose darksky-weather
brew test --retry --verbose darksky-weather
brew install --build-from-source devd
brew install --build-from-source --only-dependencies devspace
brew install --build-from-source devspace
brew install --build-from-source docker-credential-helper
brew install --build-from-source docker-gen
brew install --build-from-source --only-dependencies docker-machine-driver-hyperkit
brew install --build-from-source docker-machine-driver-hyperkit
brew install --build-from-source docker-machine-driver-vmware
brew install --build-from-source docker-machine-driver-vultr
brew install --build-from-source dockerize
brew install --build-from-source --only-dependencies dockviz
brew install --build-from-source dockviz
brew install --build-from-source dockward
brew test --retry --verbose driftctl
brew install --build-from-source drone-cli
brew install --build-from-source dvm
brew install --build-from-source emp
brew install --only-dependencies --include-test envconsul
brew test --retry --verbose envconsul
brew install --build-from-source envoy
brew test --retry --verbose etcd
brew install --build-from-source --only-dependencies fabio
brew install --build-from-source fabio
brew install --build-from-source filebeat
brew install --build-from-source flint-checker
brew install --build-from-source fsql
brew install --build-from-source gdm
brew install --build-from-source gdrive
brew install --build-from-source --only-dependencies geoipupdate
brew install --build-from-source geoipupdate
brew install --build-from-source --only-dependencies git-annex-remote-rclone
brew install --build-from-source git-annex-remote-rclone
brew install --build-from-source git-appraise
brew install --build-from-source git-sizer
brew install --build-from-source github-release
brew install --build-from-source gollum
brew install --build-from-source gotags
brew install --build-from-source gotop
brew test --retry --verbose gpm
brew install --build-from-source gx-go
brew install --build-from-source heartbeat
brew install --build-from-source --only-dependencies helmsman
brew install --build-from-source helmsman
brew install --build-from-source hivemind
brew install --build-from-source httpdiff
brew install --build-from-source ioctl
brew install --build-from-source --only-dependencies ironcli
brew install --build-from-source ironcli
brew install --build-from-source istioctl
brew install --build-from-source jabba
brew install --build-from-source jp
brew install --build-from-source jsonpp
brew install --build-from-source kedge
brew test --retry --verbose keptn
brew install --build-from-source ko
brew install --build-from-source --only-dependencies kops
brew install --build-from-source kops
brew install --build-from-source krakend
brew install --build-from-source --only-dependencies krew
brew install --build-from-source krew
brew fetch --retry ksync
brew install --build-from-source kube-linter
brew install --build-from-source --only-dependencies kube-ps1
brew install --build-from-source kube-ps1
brew install --build-from-source --only-dependencies kubectx
brew install --build-from-source kubectx
brew install --build-from-source --only-dependencies kubeless
brew install --build-from-source kubeless
brew install --build-from-source kubernetes-cli
brew install --only-dependencies --include-test kubie
brew test --retry --verbose kubie
brew install --build-from-source launch_socket_server
brew install --build-from-source --only-dependencies leaps
brew install --build-from-source leaps
brew install --build-from-source lunchy-go
brew install --build-from-source mailhog
brew install --build-from-source massren
brew install --build-from-source metricbeat
brew install --build-from-source --only-dependencies microplane
brew install --build-from-source microplane
brew install --build-from-source --only-dependencies minikube
brew install --build-from-source minikube
brew install --build-from-source modd
brew install --build-from-source mpdviz
brew install --build-from-source octant
brew install --build-from-source packer
brew install --build-from-source packetbeat
brew test --retry --verbose packr
brew install --build-from-source path-extractor
brew install --build-from-source pgweb
brew install --build-from-source piknik
brew install --build-from-source pilosa
brew install --build-from-source prometheus
brew install --build-from-source pup
brew install --build-from-source qpm
brew install --build-from-source rack
brew install --build-from-source --only-dependencies riff
brew install --build-from-source riff
brew install --build-from-source s-search
brew test --retry --verbose server-go
brew install --build-from-source --only-dependencies shellz
brew install --build-from-source shellz
brew install --build-from-source sift
brew install --build-from-source snag
brew install --build-from-source snap-telemetry
brew install --build-from-source source-to-image
brew install --build-from-source spaceinvaders-go
brew install --build-from-source --only-dependencies ssh-vault
brew install --build-from-source ssh-vault
brew install --build-from-source --only-dependencies step
brew install --build-from-source step
brew install --only-dependencies --include-test stolon
brew test --retry --verbose stolon
brew install --build-from-source stout
brew install --build-from-source sync_gateway
brew install --build-from-source --only-dependencies tanka
brew install --build-from-source tanka
brew install --build-from-source td
brew install --build-from-source teleconsole
brew install --build-from-source termshare
brew test --retry --verbose termshark
brew test --retry --verbose terraform
brew install --build-from-source terraform-inventory
brew install --build-from-source --only-dependencies terraform-provider-libvirt
brew install --build-from-source terraform-provider-libvirt
brew install --build-from-source textql
brew install --build-from-source traefik@1
brew install --build-from-source uru
brew test --retry --verbose v2ray
brew install --build-from-source --only-dependencies vault
brew install --build-from-source vault
brew install --build-from-source --only-dependencies vert
brew install --build-from-source vert
brew install --build-from-source virgil
brew test --retry --verbose vitess
brew install --build-from-source vultr
brew install --build-from-source wego

Most of these are probably formulae without ARM bottles.

On Mojave:

Error: 93 failed steps!

Error: 93 failed steps!
brew install --build-from-source aerc
brew install --build-from-source ahoy
brew install --build-from-source akamai
brew install --build-from-source amazon-ecs-cli
brew install --build-from-source apache-brooklyn-cli
brew install --build-from-source aptly
brew install --build-from-source assh
brew install --build-from-source bitrise
brew install --build-from-source buildifier
brew install --build-from-source buildozer
brew install --build-from-source caddy
brew install --build-from-source carina
brew install --build-from-source cartridge-cli
brew install --build-from-source ccat
brew install --build-from-source cf-tool
brew install --build-from-source charm
brew test --retry --verbose cloudformation-cli
brew test --retry --verbose cloudformation-cli
brew install --build-from-source collector-sidecar
brew install --build-from-source confd
brew test --rety --verbose container-structure-test
brew test --retry --verbose container-structure-test
brew install --build-from-source cql
brew install --build-from-source cwlogs
brew install --build-from-source devd
brew install --build-from-source docker-credential-helper
brew install --build-from-source docker-gen
brew install --build-from-source docker-machine-driver-hyperkit
brew install --build-from-source docker-machine-driver-vmware
brew install --build-from-source docker-machine-driver-vultr
brew install --build-from-source dockerize
brew install --build-from-source dockviz
brew install --build-from-source dockward
brew install --build-from-source dvm
brew install --build-from-source emp
brew install --build-from-source envoy
brew install --build-from-source flint-checker
brew install --build-from-source fsql
brew install --build-from-source gdm
brew test --retry --verbose gdm
brew install --build-from-source gdrive
brew install --build-from-source git-appraise
brew install --build-from-source git-sizer
brew install --build-from-source github-release
brew install --build-from-source gollum
brew install --build-from-source gotags
brew test --retry --verbose gpm
brew test --retry --verbose gpm
brew install --build-from-source gx-go
brew install --build-from-source hivemind
brew install --build-from-source httpdiff
brew install --build-from-source ironcli
brew install --build-from-source jabba
brew install --build-from-source jp
brew install --build-from-source jsonpp
brew install --build-from-source kedge
brew install --build-from-source ko
brew install --build-from-source ksync
brew install --build-from-source launch_socket_server
brew install --build-from-source leaps
brew install --build-from-source lunchy-go
brew install --build-from-source mailhog
brew install --build-from-source massren
brew install --build-from-source microplane
brew install --build-from-source modd
brew install --build-from-source mpdviz
brew test --retry --verbose packr
brew test --retry --verbose packr
brew install --build-from-source path-extractor
brew install --build-from-source pgweb
brew install --build-from-source piknik
brew install --build-from-source pup
brew install --build-from-source qpm
brew install --build-from-source rack
brew install --build-from-source s-search
brew install --build-from-source shellz
brew install --build-from-source sift
brew install --build-from-source snag
brew install --build-from-source snap-telemetry
brew install --build-from-source spaceinvaders-go
brew install --build-from-source ssh-vault
brew install --build-from-source stout
brew install --build-from-source sync_gateway
brew install --build-from-source td
brew install --build-from-source teleconsole
brew install --build-from-source termshare
brew install --build-from-source terraform-inventory
brew install --build-from-source textql
brew install --build-from-source traefik@1
brew install --build-from-source uru
brew install --build-from-source vert
brew install --build-from-source vultr
brew install --build-from-source wegor

On Catalina:

Error: 94 failed steps!

Error: 94 failed steps!
brew install --build-from-source aerc
brew install --build-from-source ahoy
brew install --build-from-source akamai
brew install --build-from-source amazon-ecs-cli
brew install --build-from-source apache-brooklyn-cli
brew install --build-from-source aptly
brew install --build-from-source assh
brew install --build-from-source bitrise
brew install --build-from-source buildifier
brew install --build-from-source buildozer
brew install --build-from-source caddy
brew install --build-from-source carina
brew install --build-from-source cartridge-cli
brew install --build-from-source ccat
brew install --build-from-source cf-tool
brew install --build-from-source charm
brew test --retry --verbose cloudformation-cli
brew test --retry --verbose cloudformation-cli
brew install --build-from-source collector-sidecar
brew install --build-from-source confd
brew test --retry --verbose container-structure-test
brew test --retry --verbose container-structure-test
brew install --build-from-source cql
brew install --build-from-source cwlogs
brew install --build-from-source devd
brew install --build-from-source docker-credential-helper
brew install --build-from-source docker-gen
brew install --build-from-source docker-machine-driver-hyperkit
brew install --build-from-source docker-machine-driver-vmware
brew install --build-from-source docker-machine-driver-vultr
brew install --build-from-source dockerize
brew install --build-from-source dockviz
brew install --build-from-source dockward
brew install --build-from-source dvm
brew install --build-from-source emp
brew install --build-from-source envoy
brew install --build-from-source flint-checker
brew install --build-from-source fsql
brew install --build-from-source gdm
brew test --retry --verbose gdm
brew install --build-from-source gdrive
brew install --build-from-source git-appraise
brew install --build-from-source git-sizer
brew install --build-from-source github-release
brew install --build-from-source gollum
brew install --build-from-source gotags
brew test --retry --verbose gpm
brew test --retry --verbose gpm
brew install --build-from-source gx-go
brew install --build-from-source hivemind
brew install --build-from-source httpdiff
brew install --build-from-source ironcli
brew install --build-from-source jabba
brew install --build-from-source jp
brew install --build-from-source jsonpp
brew install --build-from-source kedge
brew install --build-from-source ko
brew install --build-from-source krakend
brew install --build-from-source ksync
brew install --build-from-source launch_socket_server
brew install --build-from-source leaps
brew install --build-from-source lunchy-go
brew install --build-from-source mailhog
brew install --build-from-source massren
brew install --build-from-source microplane
brew install --build-from-source modd
brew install --build-from-source mpdviz
brew test --retry --verbose packr
brew test --retry --verbose packr
brew install --build-from-source path-extractor
brew install --build-from-source pgweb
brew install --build-from-source piknik
brew install --build-from-source pup
brew install --build-from-source qpm
brew install --build-from-source rack
brew install --build-from-source s-search
brew install --build-from-source shellz
brew install --build-from-source sift
brew install --build-from-source snag
brew install --build-from-source snap-telemetry
brew install --build-from-source spaceinvaders-go
brew install --build-from-source ssh-vault
brew install --build-from-source stout
brew install --build-from-source sync_gateway
brew install --build-from-source td
brew install --build-from-source teleconsole
brew install --build-from-source termshare
brew install --build-from-source terraform-inventory
brew install --build-from-source textql
brew install --build-from-source traefik@1
brew install --build-from-source uru
brew install --build-from-source vert
brew install --build-from-source vultr
brew install --build-from-source wego

Big Sur:

Error: 94 failed steps!

Error: 94 failed steps!
brew install --build-from-source aerc
brew install --build-from-source ahoy
brew install --build-from-source akamai
brew install --build-from-source amazon-ecs-cli
brew install --build-from-source apache-brooklyn-cli
brew install --build-from-source aptly
brew install --build-from-source assh
brew install --build-from-source bitrise
brew install --build-from-source buildifier
brew install --build-from-source buildozer
brew install --build-from-source caddy
brew install --build-from-source carina
brew install --build-from-source cartridge-cli
brew install --build-from-source ccat
brew install --build-from-source cf-tool
brew install --build-from-source charm
brew test --retry --verbose cloudformation-cli
brew test --retry --verbose cloudformation-cli
brew install --build-from-source collector-sidecar
brew install --build-from-source confd
brew test --retry --verbose container-structure-test
brew test --retry --verbose container-structure-test
brew install --build-from-source cql
brew install --build-from-source cwlogs
brew install --build-from-source devd
brew install --build-from-source docker-credential-helper
brew install --build-from-source docker-gen
brew install --build-from-source docker-machine-driver-hyperkit
brew install --build-from-source docker-machine-driver-vmware
brew install --build-from-source docker-machine-driver-vultr
brew install --build-from-source dockerize
brew install --build-from-source dockviz
brew install --build-from-source dockward
brew install --build-from-source dvm
brew install --build-from-source emp
brew install --build-from-source flint-checker
brew install --build-from-source fsql
brew install --build-from-source gdm
brew test --retry --verbose gdm
brew install --build-from-source gdrive
brew install --build-from-source git-appraise
brew install --build-from-source git-sizer
brew install --build-from-source github-release
brew install --build-from-source gollum
brew install --build-from-source gotags
brew test --retry --verbose gpm
brew test --retry --verbose gpm
brew install --build-from-source gx-go
brew install --build-from-source hivemind
brew install --build-from-source httpdiff
brew install --build-from-source ironcli
brew install --build-from-source jabba
brew install --build-from-source jp
brew install --build-from-source jsonpp
brew install --build-from-source kedge
brew install --build-from-source ko
brew install --build-from-source krakend
brew install --build-from-source ksync
brew install --build-from-source launch_socket_server
brew install --build-from-source leaps
brew install --build-from-source lunchy-go
brew install --build-from-source mailhog
brew install --build-from-source massren
brew install --build-from-source microplane
brew install --build-from-source modd
brew install --build-from-source mpdviz
brew test --retry --verbose packr
brew test --retry --verbose packr
brew install --build-from-source path-extractor
brew install --build-from-source pgweb
brew install --build-from-source piknik
brew install --build-from-source pup
brew install --build-from-source qpm
brew test --retry --verbose qrcp
brew install --build-from-source rack
brew install --build-from-source s-search
brew install --build-from-source shellz
brew install --build-from-source sift
brew install --build-from-source snag
brew install --build-from-source snap-telemetry
brew install --build-from-source spaceinvaders-go
brew install --build-from-source ssh-vault
brew install --build-from-source stout
brew install --build-from-source sync_gateway
brew install --build-from-source td
brew install --build-from-source teleconsole
brew install --build-from-source termshare
brew install --build-from-source terraform-inventory
brew install --build-from-source textql
brew install --build-from-source traefik@1
brew install --build-from-source uru
brew install --build-from-source vert
brew install --build-from-source vultr
brew install --build-from-source wego

[FiloSottile]

A lot of the Mojave failures are from formulae that put the repository in GOPATH/src and then run go build from outside of it, which only works in GOPATH mode, which is now disabled.

Those should be fixable by just not doing the GOPATH/src part and running go build from inside the tree.

[carlocab]

ARM failures with bottles:

aerc
container-structure-test
darksky-weather
ko
krakend

aerc is a checksum mismatch (thanks sourcehut) #71189, #71057

We also saw darksky-weather and krakend at #70446.

[roopakv]

@carlocab, Ok looks like there are only 4 more failures which i couldn't quickly figure out. Would love some help otherwise will give it a shot again tomorrow.

@circa10a could we rebase and see what fails once again to make sure that the only failures are the ones in the list above? I wonder if we missed any.

[SMillerDev]

Thanks @nklmilojevic @vvvvv @circa10a @roopakv @abhinav @Bo98 and @carlocab for all the GOPATH fixes ! Without your contributions it is impossible to get this PR merged. You can feel good knowing that you're making the world a lot better for homebrew Go users around the world! 👍 🎉

[joeshaw]

@Dreamacro

1. I use macOS to develop go programs and have a package on Homebrew
2. I wanna update the latest go version to handle compatibility issues with the new version
3. The homebrew blocked the new go version pull request for handing old packages build issue. So I can't update go to fix the compatibility issue on my machine. I have to do something like:

The Go project provides an option for this (that's also cross-platform). You can download any version, including beta and release candidate versions, that live separately from your existing Homebrew installation. For example:

$ go get golang.org/dl/go1.16
$ go1.16 download
$ go1.16 build github.com/me/mypackage

More info available here: https://golang.org/doc/manage-install#installing-multiple

Except in extreme circumstances (eg, Apple Silicon) Homebrew will never ship beta or release candidate versions, but those are the versions you should be testing your own packages with to shake out these kinds of issues before the stable version is released. This is a good way to do so without relying on Homebrew or messing up a stable installation.

[circa10a]

@carlocab, Ok looks like there are only 4 more failures which i couldn't quickly figure out. Would love some help otherwise will give it a shot again tomorrow.

@circa10a could we rebase and see what fails once again to make sure that the only failures are the ones in the list above? I wonder if we missed any.

@roopakv sorry for the delay. Rebased

[Bo98]

There's a couple PRs not quite merged yet. I'll rebase again when they're merged.

[Bo98]

I've now rebased again on master, which should have everything fixed now.

I've made a couple changes based on discussions here and in other issues:

• The bootstrap on Intel has been updated to be consistent with ARM (easier to maintain if everything is on the same version - see discussions in go.rb: use latest stable release for Go source installs #71370).
• godoc has been removed entirely. Upstream have stopped including godoc in their distributions so we should too (https://golang.org/doc/go1.13#godoc). The lack of tags also shows that it should not be bundled anymore - picking up whatever is the latest HEAD commit is not a good idea.

[carlocab]

There are 99 failures on ARM, but only one of them has been bottled:

==> brew install --build-from-source lab
==> FAILED
==> Downloading https://github.com/zaquestion/lab/archive/v0.20.0.tar.gz
==> Downloading from https://codeload.github.com/zaquestion/lab/tar.gz/v0.20.0
curl: (22) The requested URL returned error: 404 
Error: Failed to download resource "lab"
Download failed: https://github.com/zaquestion/lab/archive/v0.20.0.tar.gz

This looks like a random network failure, so we can probably ignore it.

[Bo98]

Just a couple failures, but I've already fixed them and will open a separate PR for them.

I'll go ahead and merge this now.

---

Just to clarify this point made:

"all existing formulae must compile with version X+1 before X+1 can be merged"

This isn't quite true. Depending on [email protected] is acceptable if a formula does not work with 1.16, though if it's possible to make it work on 1.16 without much effort then that's the preferred option. In this case, pretty much all the fixes were simple enough.

What we don't do is pretend the problems don't exist and knowingly leave them broken. I'm merging this now happily knowing that we aren't aware of any regressions. I thank everyone who helped out in making sure of that.

[BrewTestBot]

@Bo98 has triggered a merge.