Skip to content

chore: LEAP-516,LEAP-517: upgrade follow-redirects package to address CVE-2023-26159 #5349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 24, 2024

Conversation

jombooth
Copy link
Contributor

Upgrades follow-redirects in web/, docs/ and web/libs/editor/tests/e2e/. Methodology used was from here: yarnpkg/yarn#4986 (comment)

Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 6dad4cf
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/65b194fadc55180008ad573a

Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 6dad4cf
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/65b194fad6c591000865eaa8

@github-actions github-actions bot added the chore label Jan 23, 2024
@jombooth jombooth changed the title chore: upgrade follow-redirects package to address CVE-2023-26159 chore: LEAP-516,LEAP-517: upgrade follow-redirects package to address CVE-2023-26159 Jan 23, 2024
@jombooth
Copy link
Contributor Author

@hlomzik @Gondragos - Clicking around on the Netlify docs previews above, links seem to be working okay. Is there a different way I should be testing the docs build?

@hlomzik hlomzik changed the title chore: LEAP-516,LEAP-517: upgrade follow-redirects package to address CVE-2023-26159 chore: LEAP-516,LEAP-517: upgrade follow-redirects package to address CVE-2023-26159 Jan 24, 2024
@Gondragos
Copy link
Collaborator

@jombooth To be honest I can't say I'm an expert in this docs part. But I would say that docs were not generated this time. It looks like it needs some changes sources to do that or something like that.
As I understand here is an example of how it should look like: #4443
There is the Deploy Preview row in a table which I think might be an indication of an existing of a new build.

@jombooth
Copy link
Contributor Author

jombooth commented Jan 24, 2024

@Gondragos I think it does successfully build, then get updated to say "cancelled" for some reason. See for example: https://app.netlify.com/sites/heartex-docs/deploys/65b194384af5560008ac732c

@Gondragos
Copy link
Collaborator

@jombooth Actually, I think you're right. From what I see there, it makes sense.
I just want @hlomzik to confirm that as I believe he could have some more context.

@jombooth jombooth merged commit 59b67bb into develop Jan 24, 2024
@hlomzik hlomzik deleted the fb-LEAP-516/upgrade-follow-redirects branch January 26, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants