Skip to content

fix: BROS-76: Fix fail in Review Stream for projects with sync tags #7689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+2 −1
Open

fix: BROS-76: Fix fail in Review Stream for projects with sync tags #7689

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4497723
fix: BROS-76: Fix Syncable + Annotation history
hlomzik Jun 4, 2025
3e9b9ac
Merge branch 'develop' into 'fb-bros-76/sync-review'
hlomzik Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web/libs/editor/src/mixins/AnnotationMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ export const AnnotationMixin = types.model("AnnotationMixin", {}).views((self) =
}

// return connected annotation, not the globally selected one
return Types.getParentOfTypeString(self, "Annotation");
// if a method was triggered inside history item which is not selected, we should traverse up to it
return Types.getParentOfTypeString(self, "Annotation") ?? Types.getParentOfTypeString(self, "HistoryItem");
}

const as = self.annotationStore;
Expand Down
Loading