Skip to content

build: replace airbnb js style guide config #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Aug 6, 2025
Merged

build: replace airbnb js style guide config #1858

merged 48 commits into from
Aug 6, 2025

Conversation

mojito317
Copy link
Contributor

PR summary

Fixes: s1172
Note: An existing issue is required before opening a PR.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

Airbnb eslint rule package was used.

What is the new behavior?

Airbnb eslint rule package is removed, rules from it are moved to an internal file.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mojito317 mojito317 force-pushed the s1172-replace-airbnb-js-style-guide-config branch 2 times, most recently from 344b389 to 4f500fe Compare August 1, 2025 18:34
@mojito317 mojito317 self-assigned this Aug 1, 2025
@mojito317 mojito317 force-pushed the s1172-replace-airbnb-js-style-guide-config branch 3 times, most recently from fbfee6c to 3c7c323 Compare August 4, 2025 08:39
@mojito317 mojito317 marked this pull request as ready for review August 4, 2025 08:40
@mojito317 mojito317 requested a review from a team as a code owner August 4, 2025 08:40
@mojito317 mojito317 force-pushed the s1172-replace-airbnb-js-style-guide-config branch 2 times, most recently from 0fa494e to 8960ba7 Compare August 4, 2025 08:46
ricellis
ricellis reviewed Aug 5, 2025
View reviewed changes
Copy link
Member

@ricellis ricellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there!

@mojito317 mojito317 force-pushed the s1172-replace-airbnb-js-style-guide-config branch from 7f6bfca to dc2447a Compare August 5, 2025 14:12
@mojito317 mojito317 changed the title S1172 replace airbnb js style guide config build: replace airbnb js style guide config Aug 5, 2025
mojito317 added 16 commits August 5, 2025 16:36
@mojito317
build: replace base best practices eslint rules
c031171 
see https://github.com/airbnb/javascript/blob/eslint-config-airbnb-base-v15.0.0/packages/eslint-config-airbnb-base/rules/best-practices.js
@mojito317
build: replace base errors eslint rules
c8970d1 
see https://github.com/airbnb/javascript/blob/eslint-config-airbnb-base-v15.0.0/packages/eslint-config-airbnb-base/rules/errors.js
@mojito317
build: replace base ES6 eslint rules
902f6ba 
see https://github.com/airbnb/javascript/blob/eslint-config-airbnb-base-v15.0.0/packages/eslint-config-airbnb-base/rules/es6.js
@mojito317
build: replace base imports eslint rules
0dcc340 
see https://github.com/airbnb/javascript/blob/eslint-config-airbnb-base-v15.0.0/packages/eslint-config-airbnb-base/rules/imports.js
@mojito317
build: replace base style eslint rules
ab405de 
see https://github.com/airbnb/javascript/blob/eslint-config-airbnb-base-v15.0.0/packages/eslint-config-airbnb-base/rules/style.js
@mojito317
build: replace base variables eslint rules
3ca926d 
see https://github.com/airbnb/javascript/blob/eslint-config-airbnb-base-v15.0.0/packages/eslint-config-airbnb-base/rules/variables.js
@mojito317
build(deps-dev): remove eslint-config-airbnb-base
6a01925
@mojito317
build: use custom eslint rules
f5516db
@mojito317
fix: turn off airbnb rules on ts files
66f968b
@mojito317
fix
5d867ed
@mojito317
build: add @typescript-eslint/class-methods-use-this rule
f26590c
@mojito317
build: enable the default-case rule
b048368
@mojito317
build: enable the eqeqeq rule
a7ab1b4
@mojito317
build: enable the import/newline-after-import rule
76cbcef
@mojito317
build: enable the import/no-named-default rule
fed8c6a
@mojito317
build: enable the import/order rule
0efb484
mojito317 added 27 commits August 5, 2025 16:36
@mojito317
build: enable the no-else-return rule
c80e046
@mojito317
build: enable the no-plusplus rule
c3cea57
@mojito317
build: enable the no-promise-executor-return rule
9c10140
@mojito317
build: enable the no-redeclare rule
d16ff3b
@mojito317
build: enable the no-restricted-properties rule
c07ede7
@mojito317
build: enable the no-restricted-syntax rule
290575c
@mojito317
build: add comment on the no-undef rule
e304aa5
@mojito317
build: enable the no-unneeded-ternary rule
4ddc440
@mojito317
build: modify the no-unused-vars rule configuration
e3373d1
@mojito317
build: enable the no-useless-return rule
5c89e2d
@mojito317
build: enable the prefer-const rule
4b0c0d7
@mojito317
build: enable the prefer-destructuring rule
691ee24
@mojito317
build: enable the prefer-exponentiation-operator rule
f907159
@mojito317
build: enable the prefer-regex-literals rule
0afacef
@mojito317
fix: remove unnecessary comment
a97e53b
@mojito317
refactor: remove unnecessary param from pagination func params to avo…
724f4a4 
…id class-methods-use-this linter error
@mojito317
fix: error on default case of transient error
8ae1c78
@mojito317
fix: eqeqeq for null/undefined
a68a0ff
@mojito317
fix: diasble lines-between-class-members on fields
f3ae358
@mojito317
fix: diasble @typescript-eslint/no-unused-vars on func args
4adee61
@mojito317
refactor: enable the import/no-cycle eslint rule
e47b630
@mojito317
build: disable import/no-named-default and import/prefer-default-export
b9b5253
@mojito317
fix: remove default from not necessary functions and classes
1ce4e8d
@mojito317
fix: remove useless constructors
0855d23
@mojito317
fix: revert default as CloudantV1 imports
fafbf11
@mojito317
fix: PR feedback
a8a41db
@mojito317
fix: remove unnecessary conditional from if
f38880e
@mojito317 mojito317 force-pushed the s1172-replace-airbnb-js-style-guide-config branch from dc2447a to f38880e Compare August 5, 2025 14:36
@mojito317 mojito317 merged commit 668a818 into main Aug 6, 2025
8 checks passed
@mojito317 mojito317 deleted the s1172-replace-airbnb-js-style-guide-config branch August 6, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricellis ricellis ricellis approved these changes

Assignees

@mojito317 mojito317

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mojito317 @ricellis