-
Notifications
You must be signed in to change notification settings - Fork 159
Restart alembic versions with the table creation #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
madhav165
wants to merge
25
commits into
main
Choose a base branch
from
alembic-pending
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+330
β824
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
5543f68
Pending changes for alembic
madhav165 9fa13f3
Merge remote-tracking branch 'origin/main' into alembic-pending
madhav165 2c80963
Merge remote-tracking branch 'origin/main' into alembic-pending
madhav165 e19963d
Merge remote-tracking branch 'origin/main' into alembic-pending
madhav165 c27ce28
use bootstrap_db for e2e test_db
madhav165 d2e8891
logging tables
madhav165 ecce8d6
testing
madhav165 08999d2
testing
madhav165 44f1715
testing
madhav165 1a47eb5
remove bootstrap_db.py
madhav165 9c51df1
remove bootstrap_db
madhav165 a035023
remove bootstrap_db in tests
madhav165 8edb61d
don't change test_admin_apis
madhav165 ec5e85e
testing tests
madhav165 2d2710c
test changes to tests
madhav165 0e3758e
testing tests
madhav165 6224e14
linting fixes
madhav165 f60fd0e
Merge remote-tracking branch 'origin/main' into alembic-pending
madhav165 1361cc6
Remove commented code
madhav165 b3035a8
Merge remote-tracking branch 'origin/main' into alembic-pending
madhav165 42a19cb
Run migration from docker compose
madhav165 38058a0
Linting fixes
madhav165 4629a70
Update migration in values.yaml
madhav165 0fe0055
Use Containerfile.lite in travis
madhav165 7394886
Merge remote-tracking branch 'origin/main' into alembic-pending
madhav165 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,16 +60,8 @@ services: | |
condition: service_healthy # βΆ wait for DB | ||
redis: | ||
condition: service_started | ||
# migration: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't remove healthcheck |
||
# condition: service_completed_successfully | ||
|
||
healthcheck: | ||
test: ["CMD", "curl", "-f", "http://localhost:4444/health"] | ||
#test: ["CMD", "curl", "-f", "https://localhost:4444/health"] | ||
interval: 30s | ||
timeout: 10s | ||
retries: 5 | ||
start_period: 20s | ||
migration: | ||
condition: service_completed_successfully | ||
|
||
# volumes: | ||
# - ./certs:/app/certs:ro # mount certs folder read-only | ||
|
@@ -123,19 +115,19 @@ services: | |
# volumes: [mongodata:/data/db] | ||
# networks: [mcpnet] | ||
|
||
# migration: | ||
# #image: ghcr.io/ibm/mcp-context-forge:0.4.0 # Use the release MCP Context Forge image | ||
# image: mcpgateway/mcpgateway:latest # Use the local latest image. Run `make docker-prod` to build it. | ||
# build: | ||
# context: . | ||
# dockerfile: Containerfile | ||
# environment: | ||
# - DATABASE_URL=postgresql://postgres:${POSTGRES_PASSWORD:-mysecretpassword}@postgres:5432/mcp | ||
# command: alembic upgrade head | ||
# depends_on: | ||
# postgres: | ||
# condition: service_healthy | ||
# networks: [mcpnet] | ||
migration: | ||
#image: ghcr.io/ibm/mcp-context-forge:0.4.0 # Use the release MCP Context Forge image | ||
image: mcpgateway/mcpgateway:latest # Use the local latest image. Run `make docker-prod` to build it. | ||
build: | ||
context: . | ||
dockerfile: Containerfile.lite | ||
environment: | ||
- DATABASE_URL=postgresql://postgres:${POSTGRES_PASSWORD:-mysecretpassword}@postgres:5432/mcp | ||
command: alembic -c mcpgateway/alembic.ini upgrade head | ||
depends_on: | ||
postgres: | ||
condition: service_healthy | ||
networks: [mcpnet] | ||
|
||
############################################################################### | ||
# CACHE | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should re-enable healthchecks