-
Notifications
You must be signed in to change notification settings - Fork 210
Add support for Graphql file upload #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Graphql file upload #434
Conversation
I need this. hope it can be merged as soon as possible |
@eokoneyo Sorry for the late reply! This looks really good to me! If you could just clarify one thing, I think we can merge this in an push out a new version! |
@Alan-Cha That's great to hear, I wasn't sure if this was a feature that's in line with the library's roadmap. Since you're okay with this, I think there'll be a need to add details about supporting file upload to the README file |
@eokoneyo Ah, the public roadmap is outdated but we welcome any suggestions and new features. Do you think you could flesh out the documentation? I think you are more qualified to describe what is going on. If you can do that, then I can merge and push out a new release. |
I actually stumbled on the roadmap today, I'll be sure to add in any new features or suggestions I might have and yes, I'll add in the documentation for this. |
…oposal Signed-off-by: Eyo O. Eyo <[email protected]> add more test cases for generated schema Signed-off-by: Eyo Okon Eyo <[email protected]>
Signed-off-by: Eyo O. Eyo <[email protected]> Signed-off-by: Eyo Okon Eyo <[email protected]>
…er to REST endpoint Signed-off-by: Eyo O. Eyo <[email protected]> Signed-off-by: Eyo Okon Eyo <[email protected]>
Signed-off-by: Eyo Okon Eyo <[email protected]>
… for file uploads Signed-off-by: Eyo Okon Eyo <[email protected]>
Signed-off-by: Eyo Okon Eyo <[email protected]>
Signed-off-by: Eyo Okon Eyo <[email protected]>
Signed-off-by: Eyo Okon Eyo <[email protected]>
@Alan-Cha I added in documentation, also some slight modifications to allow the users specify config options pertaining to how the file upload is processed. I also wanted to point out that my changes make it so this module has to run within a NodeJS context because of the file upload. |
@eokoneyo Everything looks great! I made some small adjustments and also rebased it but because I do not have push access to your branch, I had to create my own and filed a new PR #435. I will merge everything in through said PR and close this one. I know you have some other PRs that you submitted a while ago. I plan on looking on them as well as all of the other stale PRs. I'm trying to get back into maintaining this project. In the meantime, feel free to add suggestions to the roadmap and thanks again for this great contribution! |
v2.6.0 is out! |
Hi There,
Really great work with what's been done so far with the implementation to translate OAS to GraphQL, I recently had some reason whilst using this library to support file uploads for the GraphQL server running on the schema generated by the library. I know there's no support for it and it's already been brought up as seen here #220
So I added support for file uploads, Here are the considerations I made;
multipart/form-data
are processed as suchI would appreciate feedback pertaining to this and like to see this merged in, as I'm using the changes in here as a patch to the library for upload support in my team.