-
Notifications
You must be signed in to change notification settings - Fork 263
Make widget messages match with IPywidgets #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gibiansky It worked. I was able to create a button. I will test this more extensively today. |
@gibiansky It still has some issues with other widgets. Buttons work just fine, but their appearance has changed a lot so it looks different. |
Is there anything I can do to help here? I'd like to get a 4.0-compatible release out soon. |
It's been a week, so @jdfreder might be free to give us some guidance related to the new widget messaging spec. Other than that, the only solution is to go for hit and trial methods, but we still wouldn't be sure how to deal with the bigger changes, such as the frontend trying to open a comm on kernel startup. |
The changes to the message spec involve sending the entire widget state along with the comm open message, this means the specially named The front-end now opens a comm on startup as the workaround included here: jupyter-widgets/ipywidgets#62 We wanted to get a change into the message spec for 4.0, but were instead told that wouldn't happen, and that we should instead implement the message as a comm message. In the future, this will not be the case. |
Thanks for the input @jdfreder 👍 I understood the first part (sending initial state with |
The ihaskell-widgets should send messages identical to what the IPywidgets send. This has not been tested as there are some unresolved issues in IHaskell that surface only if ipywidgets is installed.
Is it possible that you are missing some state, so the full state is not being sent to the front-end? There's a lot of state that could be easy to miss, especially that in the base DOMWidget class: https://github.com/ipython/ipywidgets/blob/master/ipywidgets/widgets/widget.py#L455-L502 If that state isn't pushed, it may cause errors. |
Yeah. It turns out that most of the example notebooks, which I'm using to test the current state, made use of boxes. Boxes have seen some twiddling with their properties, which would need to be fixed. @jdfreder Thanks once again for the help 👍 |
@gibiansky All the widgets we had have been brought up to what 4.0 requires. Some new widgets have been added to |
Make widget messages match with IPywidgets
The ihaskell-widgets should send messages identical to what the
IPywidgets send. This has not been tested as there are some unresolved
issues in IHaskell that surface only if ipywidgets is installed.