Skip to content

Fix button using both databinding and manual updates #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tom-Willemsen
Copy link
Member

@Tom-Willemsen Tom-Willemsen commented Jul 9, 2025

Description of work

Root issue was using both databinding and asyncExecs to update the same UI state.

To test:

  • Start IBEX GUI with NICOSDAEMON switched OFF
  • Run button is disabled
  • Add some actions in the script generator
  • Run button remains disabled
  • Start NICOSDAEMON
  • Run button becomes enabled after a short delay
  • Restart the client, run button should be enabled
  • Kill NICOSDAEMON, run button should disable

This is manual, I don't think there is much cost/benefit to adding an entire squish test for this (and it can't be tested at the unit-test level as it's all UI code).

Ticket

Fixes ISISComputingGroup/IBEX#8697

Acceptance criteria

  • State of "run" button always matches state of underlying NICOS connection

Unit tests

This is a change in the UI layer - it is not possible to unit test easily. This is best-tested manually.


Code Review

Final Steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIFI: script generator run button after restarting nicosdaemon
1 participant