Fix button using both databinding and manual updates #1797
+8
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Root issue was using both databinding and
asyncExec
s to update the same UI state.To test:
This is manual, I don't think there is much cost/benefit to adding an entire squish test for this (and it can't be tested at the unit-test level as it's all UI code).
Ticket
Fixes ISISComputingGroup/IBEX#8697
Acceptance criteria
Unit tests
This is a change in the UI layer - it is not possible to unit test easily. This is best-tested manually.
Code Review
check_opi_format.py
script in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?Final Steps