[BUG] display of 3D `BlockSparseArray` errors

[ogauthe]

r = blockedrange([1])
a = BlockSparseArray{Float64}(undef,r,r,r);
display(a)

1×1×1-blocked 1×1×1 BlockSparseArray{Float64, 3, Array{Float64, 3}, …, …}:
[:, :, 1] =
 ERROR: TypeError: in SparseSubArrayBlocks, in BlockType, expected BlockType<:AbstractMatrix{Float64}, got Type{Array{Float64, 3}}
Stacktrace:
  [1] call(::BlockSparseArrays.BlockSparseArrayInterface, ::typeof(blocks), a::SubArray{Float64, 2, BlockSparseArray{…}, Tuple{…}, false})
    @ BlockSparseArrays ~/.julia/packages/BlockSparseArrays/7xJ0V/src/blocksparsearrayinterface/blocksparsearrayinterface.jl:341
  [2] (::DerivableInterfaces.InterfaceFunction{…})(args::SubArray{…}; kwargs::@Kwargs{})
    @ DerivableInterfaces ~/.julia/packages/DerivableInterfaces/Vk7kH/src/interface_function.jl:17
  [3] blocks(a::SubArray{Float64, 2, BlockSparseArray{…}, Tuple{…}, false})
    @ BlockSparseArrays ~/.julia/packages/BlockSparseArrays/7xJ0V/src/abstractblocksparsearray/wrappedabstractblocksparsearray.jl:72
  [4] isstored(::SubArray{Float64, 2, BlockSparseArray{…}, Tuple{…}, false}, ::Int64, ::Int64)
    @ BlockSparseArrays ~/.julia/packages/BlockSparseArrays/7xJ0V/src/abstractblocksparsearray/wrappedabstractblocksparsearray.jl:344
  [5] replace_in_print_matrix(A::SubArray{Float64, 2, BlockSparseArray{…}, Tuple{…}, false}, i::Int64, j::Int64, s::String)
    @ BlockSparseArrays ~/.julia/packages/BlockSparseArrays/7xJ0V/src/abstractblocksparsearray/wrappedabstractblocksparsearray.jl:351
  [6] print_matrix_row(io::IOContext{…}, X::AbstractVecOrMat, A::Vector{…}, i::Int64, cols::Vector{…}, sep::String, idxlast::Int64)
    @ Base ./arrayshow.jl:120
  [7] _print_matrix(io::IOContext{…}, X::AbstractVecOrMat, pre::String, sep::String, post::String, hdots::String, vdots::String, ddots::String, hmod::Int64, vmod::Int64, rowsA::UnitRange{…}, colsA::UnitRange{…})
    @ Base ./arrayshow.jl:213
  [8] print_matrix(io::IOContext{…}, X::SubArray{…}, pre::String, sep::String, post::String, hdots::String, vdots::String, ddots::String, hmod::Int64, vmod::Int64)
    @ Base ./arrayshow.jl:171
  [9] _show_nd(io::IOContext{…}, a::AbstractArray, print_matrix::typeof(Base.print_matrix), show_full::Bool, axs::Tuple{…})
    @ Base ./arrayshow.jl:322
 [10] show_nd(io::IOContext{…}, a::BlockSparseArray{…}, print_matrix::Function, show_full::Bool)
    @ Base ./arrayshow.jl:277
 [11] print_array
    @ ./arrayshow.jl:359 [inlined]
 [12] macro expansion
    @ ~/.julia/packages/GPUArraysCore/aNaXo/src/GPUArraysCore.jl:206 [inlined]
 [13] print_array(io::IOContext{Base.TTY}, X::BlockSparseArray{Float64, 3, Array{…}, SparseArraysBase.SparseArrayDOK{…}, Tuple{…}})
    @ BlockSparseArrays ~/.julia/packages/BlockSparseArrays/7xJ0V/src/abstractblocksparsearray/wrappedabstractblocksparsearray.jl:359
 [14] show(io::IOContext{…}, ::MIME{…}, X::BlockSparseArray{…})
    @ Base ./arrayshow.jl:399
 [15] (::OhMyREPL.var"#7#8"{REPL.REPLDisplay{REPL.LineEditREPL}, MIME{Symbol("text/plain")}, Base.RefValue{Any}})(io::IOContext{Base.TTY})
    @ OhMyREPL ~/.julia/packages/OhMyREPL/bkUhZ/src/output_prompt_overwrite.jl:23
 [16] with_repl_linfo(f::Any, repl::REPL.LineEditREPL)
    @ REPL ~/.julia/juliaup/julia-1.11.3+0.x64.linux.gnu/share/julia/stdlib/v1.11/REPL/src/REPL.jl:661
 [17] display
    @ ~/.julia/packages/OhMyREPL/bkUhZ/src/output_prompt_overwrite.jl:6 [inlined]
 [18] display
    @ ~/.julia/juliaup/julia-1.11.3+0.x64.linux.gnu/share/julia/stdlib/v1.11/REPL/src/REPL.jl:372 [inlined]
 [19] display(x::Any)
    @ Base.Multimedia ./multimedia.jl:340
 [20] top-level scope
    @ REPL[34]:1
Some type information was truncated. Use `show(err)` to see complete types.

Displaying any higher dimension array also fails. 0D, 1D and 2D are fine.

BlockSparseArrays v0.3.0

[mtfishman]

Thanks for the report, we'll look into it.

[mtfishman]

@ogauthe this should be fixed now if you upgrade all of your packages (in particular it was fixed by the latest version of SparseArraysBase.jl).

[ogauthe]

Thank you for the fix. I found a few other issues, I can open separate issues. They seem unrelated to #41 .

• BlockSparseVector displays sparse zeros as 0 instead of .

bsa = BlockSparseArray{Float64}(undef,[2,2])
eachblockstoredindex(bsa)
display(eachblockstoredindex(bsa))
display(bsa)

0-element Dictionaries.Dictionary{CartesianIndex{1}, Block{1, Int64}}

2-blocked 4-element BlockSparseVector{Float64, Vector{Float64}, …, …}:
 0.0
 0.0
 ───
 0.0
 0.0

This is peculiar to dimension 1, display(BlockSparseArray{Float64}(undef,[2,2], [1])) is fine.

• display(view is broken for a full view:

display(view(bsa, :))  # ok
v = view(bsa, :, :);  # ok
display(v)  # MethodError

4×1 view(::BlockSparseMatrix{Float64, Matrix{Float64}, …, …}, :, :) with eltype Float64 with indices BlockedOneTo([2, 4])×BlockedOneTo([1]):
ERROR: MethodError: no method matching Base.Slice(::Vector{Int64})
The type `Base.Slice` exists, but no method is defined for this combination of argument types when trying to construct it.

Closest candidates are:
  Base.Slice(::Base.Slice)
   @ Base indices.jl:385
  Base.Slice(::T) where T<:AbstractUnitRange
   @ Base indices.jl:383

Stacktrace:
  [1] adapt_structure(to::Type, r::Base.Slice{BlockedOneTo{Int64, Vector{Int64}}})
    @ Adapt ~/.julia/packages/Adapt/YR1WS/src/base.jl:82
  [2] adapt
    @ ~/.julia/packages/Adapt/YR1WS/src/Adapt.jl:40 [inlined]
  [3] _adapt_tuple_structure
    @ ~/.julia/packages/Adapt/YR1WS/src/base.jl:14 [inlined]
  [4] adapt_structure
    @ ~/.julia/packages/Adapt/YR1WS/src/base.jl:9 [inlined]
  [5] adapt
    @ ~/.julia/packages/Adapt/YR1WS/src/Adapt.jl:40 [inlined]
  [6] adapt_structure(to::Type, A::SubArray{Float64, 2, BlockSparseMatrix{…}, Tuple{…}, false})
    @ Adapt ~/.julia/packages/Adapt/YR1WS/src/wrappers.jl:10
  [7] adapt(to::Type, x::SubArray{Float64, 2, BlockSparseMatrix{…}, Tuple{…}, false})
    @ Adapt ~/.julia/packages/Adapt/YR1WS/src/Adapt.jl:40
  [8] print_array(io::IOContext{Base.TTY}, X::SubArray{Float64, 2, BlockSparseMatrix{…}, Tuple{…}, false})
    @ BlockSparseArrays ~/.julia/packages/BlockSparseArrays/1uOnj/src/abstractblocksparsearray/wrappedabstractblocksparsearray.jl:365
  [9] show(io::IOContext{Base.TTY}, ::MIME{Symbol("text/plain")}, X::SubArray{Float64, 2, BlockSparseMatrix{…}, Tuple{…}, false})
    @ Base ./arrayshow.jl:399
 [10] (::OhMyREPL.var"#7#8"{REPL.REPLDisplay{REPL.LineEditREPL}, MIME{Symbol("text/plain")}, Base.RefValue{Any}})(io::IOContext{Base.TTY})
    @ OhMyREPL ~/.julia/packages/OhMyREPL/bkUhZ/src/output_prompt_overwrite.jl:23
 [11] with_repl_linfo(f::Any, repl::REPL.LineEditREPL)
    @ REPL ~/.julia/juliaup/julia-1.11.3+0.x64.linux.gnu/share/julia/stdlib/v1.11/REPL/src/REPL.jl:661
 [12] display
    @ ~/.julia/packages/OhMyREPL/bkUhZ/src/output_prompt_overwrite.jl:6 [inlined]
 [13] display
    @ ~/.julia/juliaup/julia-1.11.3+0.x64.linux.gnu/share/julia/stdlib/v1.11/REPL/src/REPL.jl:372 [inlined]
 [14] display(x::Any)
    @ Base.Multimedia ./multimedia.jl:340
 [15] top-level scope
    @ REPL[104]:1
Some type information was truncated. Use `show(err)` to see complete types.

This is unaffected by blocks being written or not.

[mtfishman]

Got it, can you open separate issues for those so we can keep track of them more easily?