Skip to content

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Feb 6, 2025

In combination with ITensor/NamedDimsArrays.jl#33, this makes sure the domain of the operator is properly dualed.

Todo:

  • Add tests.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.50%. Comparing base (a9614a1) to head (7af59e5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   69.50%   69.50%           
=======================================
  Files          13       13           
  Lines         551      551           
=======================================
  Hits          383      383           
  Misses        168      168           
Flag Coverage Δ
docs 27.82% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman changed the title [WIP] Use dual to take the dual of the codomain when building symmetric operators [WIP] Use dual to take the dual of the domain when building symmetric operators Feb 6, 2025
@mtfishman mtfishman changed the title [WIP] Use dual to take the dual of the domain when building symmetric operators Use dual to take the dual of the domain when building symmetric operators Feb 6, 2025
@mtfishman mtfishman marked this pull request as ready for review February 6, 2025 20:05
@mtfishman mtfishman closed this Feb 7, 2025
@mtfishman mtfishman reopened this Feb 7, 2025
@mtfishman
Copy link
Member Author

The remaining test failures will be fixed by ITensor/TypeParameterAccessors.jl#26 and ITensor/BlockSparseArrays.jl#40.

@mtfishman mtfishman closed this Feb 9, 2025
@mtfishman mtfishman reopened this Feb 9, 2025
@mtfishman mtfishman closed this Feb 10, 2025
@mtfishman mtfishman reopened this Feb 10, 2025
@mtfishman mtfishman closed this Feb 10, 2025
@mtfishman mtfishman reopened this Feb 10, 2025
@mtfishman mtfishman merged commit f97c3a4 into main Feb 10, 2025
12 checks passed
@mtfishman mtfishman deleted the dual_op branch February 10, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant