Skip to content

sparse constructor, zero value to kwarg, constructors with splatted dims #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 6, 2025

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Mar 5, 2025

Fixes #40, fixes #42.

Also turns the function used by getunstoredindex into a keyword argument called getunstored (before it was an argument, which wasn't good for constructors where the dims are splatted).

To-do

  • More tests.

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 68.49315% with 46 lines in your changes missing coverage. Please review.

Project coverage is 74.88%. Comparing base (4e94eea) to head (d01eb1f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/oneelementarray.jl 63.20% 39 Missing ⚠️
src/sparsearraydok.jl 71.42% 4 Missing ⚠️
src/abstractsparsearray.jl 88.46% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   71.49%   74.88%   +3.39%     
==========================================
  Files           7        7              
  Lines         435      450      +15     
==========================================
+ Hits          311      337      +26     
+ Misses        124      113      -11     
Flag Coverage Δ
docs 35.71% <6.84%> (-1.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman mtfishman changed the title [WIP] sparse constructor, zero value to kwarg, constructors with splatted dims sparse constructor, zero value to kwarg, constructors with splatted dims Mar 5, 2025
@mtfishman mtfishman marked this pull request as ready for review March 5, 2025 19:26
@mtfishman mtfishman requested a review from lkdvos March 5, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants