Skip to content

Option 'insecure' for Prometheus #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

Conversation

jrauh01
Copy link
Collaborator

@jrauh01 jrauh01 commented Feb 18, 2025

Add checkbox to configure 'insecure' option for Prometheus.

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Feb 18, 2025
@jrauh01 jrauh01 requested a review from lippserd February 18, 2025 13:11
'label' => $this->translate('Insecure'),
'checkedValue' => 'true',
'uncheckedValue' => 'false',
'value' => ($kconfig[KConfig::PROMETHEUS_INSECURE]->value ?? null) === 'true',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may use ?-> here.

Add checkbox to configure 'insecure' option for Prometheus
@jrauh01 jrauh01 force-pushed the insecure-prometheus-connection branch from 185ba0f to c72b7d5 Compare May 5, 2025 09:54
@jrauh01 jrauh01 requested a review from lippserd May 5, 2025 09:54
@jrauh01 jrauh01 self-assigned this May 20, 2025
@jrauh01 jrauh01 merged commit 8511086 into main May 20, 2025
5 checks passed
@jrauh01 jrauh01 deleted the insecure-prometheus-connection branch May 20, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants