Skip to content

Abstorage #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 51 commits into from
Jun 22, 2020
Merged

Abstorage #47

merged 51 commits into from
Jun 22, 2020

Conversation

rohe
Copy link
Contributor

@rohe rohe commented Jun 8, 2020

Included the possibility to use a persistent storage.
One consequence of the work was that KeyJar was split into KeyJar and KeyIssuer.

@jschlyter jschlyter self-requested a review June 10, 2020 06:21
Copy link
Collaborator

@jschlyter jschlyter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good. Addressing backwards compatibility would help a lot.

@jschlyter
Copy link
Collaborator

KeyJar.__getitem__ () previously defined to return all keybundles that belong to an entity. Now they return something different, breaking things. How can we address this? This was previously (in my case) to add keys to a KeyBundle in a KeyJar.

@rohe
Copy link
Contributor Author

rohe commented Jun 17, 2020

KeyJar.getitem(item) now returns the KeyIssuer instance that is bound to the issuer identifier item.

To get the same behaviour as before you now have to do:

keyjar[item].get_bundles()

key jar[item].all_keys() will return all keys irrespective of in which key bundle they reside.

@jschlyter
Copy link
Collaborator

Should KeyJar[x] not raise KeyError if no such KeyIssuer exists? Silently creating one seems strange.

@rohe
Copy link
Contributor Author

rohe commented Jun 18, 2020

Yes it should.

@rohe rohe merged commit 02de6f2 into develop Jun 22, 2020
@rohe rohe deleted the abstorage branch June 22, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants