Timezone awareness

[peppelinux]

this PR fixed the datetime utcnow timestamp that still returned a non utc timestamp

[rohe]

As you commented in another communication. CryptoJWT 1.6.0 is indeed on PyPI.
So we should revert that change.

[peppelinux]

As you commented in another communication. CryptoJWT 1.6.0 is indeed on PyPI. So we should revert that change.

fixed here
df56512

we just have to squash before merging

[c00kiemon5ter]

why do we need to strip the timezone information?

[peppelinux]

naive and aware datetime can't be compared, so for retrocompatibility I operate with aware datetime but always return naive datetime

[peppelinux]

considering that standard requries utc datetime, it's not important to have it with timezone

[c00kiemon5ter]

What are those comparisons?

It is important it to have it with timezone to ensure that operations on time are done in the needed timezone.
I would argue we need to do the opposite - have all datetimes in UTC to ensure calculations are correct. So, the comparisons that take place, should also have dates loaded as UTC.

[peppelinux]

the comparison doesn't happen here but later in a unit test

______________________________________________________________________________________________ test_time_a_while_ago _______________________________________________________________________________________________

    def test_time_a_while_ago():
        dt = datetime.utcnow()
        t = time_a_while_ago(seconds=10)
>       delta = dt - t  # slightly less than 10
E       TypeError: can't subtract offset-naive and offset-aware datetimes

tests/test_03_time_util.py:204: TypeError

considering that standard require UTC timestamp I didn't see any needs to carrying aware datetimes in the code BUT you kow that I'ma good boy that can spend some more effort to get all happy :)

Roland approved, do we have to put another change or do you think that's good enough as is?

[c00kiemon5ter]

If we are going to change .utcnow() to .now(utc) I think we should do it everywhere.
If we don't want to do it, then let's not do it at all.

[peppelinux]

I don't know the conseguences to other libraries and behaviours
I preferred to let the type be the same as before to prevent any breaking changes with this release

that's the answer, feel free to open an issue to keep track of this

[peppelinux]

@rohe @c00kiemon5ter can we merge this as it is or do I have to return a tz aware datetime and fix the unit test as well?

[c00kiemon5ter]

@rohe @c00kiemon5ter can we merge this as it is or do I have to return a tz aware datetime and fix the unit test as well?

go forward!

[rohe]

Absolutely, merge it !

[peppelinux]

Ok guys, just to tell that the only other place where utcnow is used is here

JWTConnect-Python-OidcMsg/src/oidcmsg/oidc/identity_assurance.py

Line 62 in abbf83b

ltz = datetime.datetime.utcnow().astimezone().tzinfo

and that's just to get the TZINFO from the host