Squash internal attribute representation #556
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Explanation
We discussed the removal of internal representation mapping in pysaml2 in VC. This is a minimal PR that implements full transparant SAML attribute transportation through pysaml/satosa stack. This means external attributes should now be configured in their original SAML rerpesentation in internal_attributes.yaml instead of internal(short)Name, also known as the .to dict in attributemaps.
The PR is intended as a discussion start and points to the places where pysaml2 touches external to internal mapping and back.