Skip to content

[WiP] Disable weak xmlsec algorithms #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WiP] Disable weak xmlsec algorithms #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7f6aef
Disabled weak algorithms following Kantara SAML V2.0 Implementation P…
peppelinux Jul 20, 2019
4f8a4f3
Disabled xmlsec algs as configurable configuration paramenter
peppelinux Aug 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/saml2/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
COMMON_ARGS = [
"debug",
"entityid",
"xmlsec_disabled_algs",
"xmlsec_binary",
"key_file",
"cert_file",
Expand Down Expand Up @@ -189,6 +190,7 @@ class Config(object):
def __init__(self, homedir="."):
self._homedir = homedir
self.entityid = None
self.xmlsec_disabled_algs = []
self.xmlsec_binary = None
self.xmlsec_path = []
self.debug = False
Expand Down
2 changes: 2 additions & 0 deletions src/saml2/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,8 @@ def entity_descriptor(confd):
_add_attr_to_entity_attributes(entd.extensions, attr)

for item in algorithm_support_in_metadata(confd.xmlsec_binary):
if item.algorithm in getattr(confd, 'xmlsec_disabled_algs'):
continue
if not entd.extensions:
entd.extensions = md.Extensions()
entd.extensions.add_extension_element(item)
Expand Down