Skip to content

fix(input-group, textarea): label position #15941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2025
+20 −41
Merged

fix(input-group, textarea): label position #15941

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6e5f58
fix(input-group, textarea): label position
desig9stein Jun 16, 2025
24b39ce
Merge branch '19.2.x' into mpopov/fix-input-label-position-19-2
desig9stein Jun 19, 2025
924f647
Merge branch '19.2.x' into mpopov/fix-input-label-position-19-2
simeonoff Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 20 additions & 41 deletions projects/igniteui-angular/src/lib/core/styles/components/input/_input-group-theme.scss
View file
Original file line number Diff line number Diff line change
@@ -396,19 +396,15 @@

@if $variant == 'material' {
%form-group-display--border {
--label-position: calc((#{var-get($theme, 'size')} / 2) - #{rem(1px)});


&:has(input:-webkit-autofill, input:autofill) {
%igx-input-group__notch--border {
border-block-start-color: transparent;
}

%form-group-label {
--label-position: #{sizable(18px, 22px, 26px)};

transform: translateY(calc(var(--label-position) * -1));
margin-top: 0;
overflow: hidden;
will-change: font-size, color, transform;
}
@extend %form-group-label--float-border;
}
}
}
@@ -1005,11 +1001,9 @@

@if $variant == 'material' {
%form-group-label--float {
--floating-label-position: -73%;

@include type-style('caption');

transform: translateY(var(--floating-label-position));
translate: 0 -73%;
}
}

@@ -1090,12 +1084,19 @@
}

%form-group-label--float-border {
--label-position: #{sizable(18px, 22px, 26px)};

transform: translateY(calc(var(--label-position) * -1));
translate: 0 calc(var(--label-position) * -1);
margin-top: 0;
overflow: hidden;
will-change: font-size, color, transform;
will-change: font-size, color, transform, translate;
}

%textarea-group {
// 3 lines * 22px + 8px bottom padding + 8px top padding
--textarea-size: #{sizable(
rem(82px, map.get($base-scale-size, 'compact')),
rem(82px, map.get($base-scale-size, 'cosy')),
rem(82px, map.get($base-scale-size, 'comfortable'))
)};
}

@if $variant == 'material' {
@@ -1139,12 +1140,6 @@
}

%form-group-textarea-group-bundle {
// 3 lines * 22px + 8px bottom padding + 8px top padding
--textarea-size: #{sizable(
rem(82px, map.get($base-scale-size, 'compact')),
rem(82px, map.get($base-scale-size, 'cosy')),
rem(82px, map.get($base-scale-size, 'comfortable'))
)};
min-height: var(--textarea-size) !important;
height: auto !important;

@@ -1156,12 +1151,12 @@
@if $material-theme {
%form-group-textarea-label {
top: calc($input-top-padding - #{rem(1px)});
margin-block-end: auto;
}

%textarea-group--outlined {
%form-group-textarea-label {
top: calc($input-top-padding - #{rem(3px)});
margin-block-end: auto;
}
}

@@ -1171,16 +1166,10 @@
}
}

%textarea-group-label--focused {
transform: translateY(0);
top: calc(#{$input-top-padding} / 4);
}

%textarea-group-label--filled--border,
%textarea-group-label--focused--border {
top: 0;
transform: translateY(-50%);
margin-block-end: auto !important;
translate: 0 -50%;
}

%textarea-group-notch--focused {
@@ -1361,20 +1350,14 @@
}

%form-group-textarea {
--textarea-size: #{sizable(
rem(82px, map.get($base-scale-size, 'compact')),
rem(82px, map.get($base-scale-size, 'cosy')),
rem(82px, map.get($base-scale-size, 'comfortable'))
)};

min-height: var(--textarea-size);
height: auto;
resize: vertical;
overflow: hidden;

@if $material-theme {
padding: 0;
inset-block-start: rem(-3px);
margin-block-start: rem(20px) !important;
}

// resets typography styles
@@ -1390,14 +1373,10 @@
%form-group-textarea-group-bundle-main {
overflow: hidden;

@if $material-theme or $indigo-theme {
@if $indigo-theme {
height: calc(100% - #{rem(2px)});
top: rem(1px);
}

@if $material-theme {
padding-block-start: $input-top-padding;
}
}

%form-group-textarea--disabled {

Unchanged files with check annotations Beta

View file
src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts
this.colsWidth = event.target.value;
}
public onColEnter(event: IDropBaseEventArgs, rowIndex, colIndex) {

Check warning on line 170 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (22.x) 

'event' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 170 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (20.x) 

'event' is defined but never used. Allowed unused args must match /^_/u
this.collection[rowIndex][colIndex].hovered = true;
}
public onColLeave(event: IDropBaseEventArgs, rowIndex, colIndex) {

Check warning on line 174 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (22.x) 

'event' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 174 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (20.x) 

'event' is defined but never used. Allowed unused args must match /^_/u
this.collection[rowIndex][colIndex].hovered = false;
}
this.resizeVisible = true;
}
public onBlur(event, rowIndex, colIndex) {

Check warning on line 235 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (22.x) 

'event' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 235 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (20.x) 

'event' is defined but never used. Allowed unused args must match /^_/u
this.cellSelected = null;
this.collection[rowIndex][colIndex].selected = false;
this.resizeVisible = false;
event.target.setPointerCapture(event.pointerId);
}
public pointerMoveResizeLeft(event, cellRef, rowIndex, colIndex) {

Check warning on line 250 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (22.x) 

'rowIndex' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 250 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (20.x) 

'rowIndex' is defined but never used. Allowed unused args must match /^_/u
if (this.dragStarted) {
const curDistance = this.dragStartX - event.pageX;
const minIncrease = -this.curResizedCell.colSpan;
}
}
public pointerMoveResizeRight(event, cellRef, rowIndex, colIndex) {

Check warning on line 262 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (22.x) 

'rowIndex' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 262 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (22.x) 

'cellRef' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 262 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (20.x) 

'rowIndex' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 262 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (20.x) 

'cellRef' is defined but never used. Allowed unused args must match /^_/u
if (this.dragStarted) {
const curDistance = event.pageX - this.dragStartX;
const maxIncrease = this.colsCount - (colIndex + this.curResizedCell.colSpan);
}
}
public pointerUpResizeRight(event, cellRef, rowIndex, colIndex) {

Check warning on line 271 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (22.x) 

'cellRef' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 271 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (22.x) 

'event' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 271 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (20.x) 

'cellRef' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 271 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (20.x) 

'event' is defined but never used. Allowed unused args must match /^_/u
this.dragStarted = false;
this.resizeVisible = false;
this.colSpanIncrease = 0;
}
public pointerUpResizeLeft(event, cellRef, targetRowIndex, targetColIndex) {

Check warning on line 351 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (22.x) 

'event' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 351 in src/app/grid-multi-row-layout-config/grid-mrl-config.sample.ts

GitHub Actions / run-tests (20.x) 

'event' is defined but never used. Allowed unused args must match /^_/u
this.dragStarted = false;
this.resizeVisible = false;
View file
src/app/drop-down/drop-down-virtual/drop-down-virtual.component.ts
return `${this.remoteService.url}?$count=true&$skip=${state.startIndex}&$top=${chunkSize}`;
};
// eslint-disable-next-line prefer-spread
this.localItems = Array.apply(null, { length: 2000 }).map((e, i) => ({

Check warning on line 41 in src/app/drop-down/drop-down-virtual/drop-down-virtual.component.ts

GitHub Actions / run-tests (22.x) 

'e' is defined but never used. Allowed unused args must match /^_/u

Check warning on line 41 in src/app/drop-down/drop-down-virtual/drop-down-virtual.component.ts

GitHub Actions / run-tests (20.x) 

'e' is defined but never used. Allowed unused args must match /^_/u
name: `Item ${i + 1}`,
id: i
}));