Skip to content

refactor keyboard navigation tests #6586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Feb 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
37f4feb
chore(*): update keyBoard navigation tests
nrobakova Jan 28, 2020
8f47a72
Merge branch 'SKrastev/refactor-forOf-tests' of https://github.com/Ig…
nrobakova Jan 28, 2020
3c7be32
chore(*): update keyBoardNavigation tests
nrobakova Jan 29, 2020
681e2a1
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
nrobakova Feb 3, 2020
883fec6
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
nrobakova Feb 3, 2020
218b01d
chore(*): update keyBoard navigation tests
nrobakova Feb 3, 2020
7504d88
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
nrobakova Feb 3, 2020
2a922f2
chore(*): update failing tests
nrobakova Feb 3, 2020
fa81f71
chore(*): update for failing tests
nrobakova Feb 3, 2020
7b74b70
chore(*): update failing tests
nrobakova Feb 3, 2020
85445c2
chore(*): update failing tests
nrobakova Feb 3, 2020
b82ddc8
chore(*): update failing tests
nrobakova Feb 3, 2020
3551243
chore(*): update failing tests
nrobakova Feb 3, 2020
bb41dca
Merge branch 'master' into nrobakova/refactor-keyboardNav-tests
nrobakova Feb 3, 2020
819fd99
chore(*): organize test to compileComponents for describe
nrobakova Feb 4, 2020
d3598f3
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
nrobakova Feb 4, 2020
2825f7c
Merge branch 'nrobakova/refactor-keyboardNav-tests' of https://github…
nrobakova Feb 4, 2020
1ba895f
chore(*): update for lint error
nrobakova Feb 4, 2020
5a4009d
chore(*): resolve conflicts
nrobakova Feb 5, 2020
f662de2
Merge branch 'master' into nrobakova/refactor-keyboardNav-tests
nrobakova Feb 6, 2020
6bc542a
Merge branch 'master' into nrobakova/refactor-keyboardNav-tests
kdinev Feb 7, 2020
6e1e875
Merge branch 'master' into nrobakova/refactor-keyboardNav-tests
nrobakova Feb 10, 2020
cc5f569
Merge branch 'master' into nrobakova/refactor-keyboardNav-tests
kdinev Feb 10, 2020
17715f8
chore(*): address review comments
nrobakova Feb 11, 2020
f564edf
Merge branch 'master' into nrobakova/refactor-keyboardNav-tests
zdrawku Feb 11, 2020
db4d0f2
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
nrobakova Feb 11, 2020
5b445d0
chore(*): remove tick for tests without scrolls
nrobakova Feb 11, 2020
3dc4804
Merge branch 'nrobakova/refactor-keyboardNav-tests' of https://github…
nrobakova Feb 11, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { SampleTestData } from '../../test-utils/sample-test-data.spec';
import { IColumnResized } from '../../test-utils/grid-interfaces.spec';
import { MultiColumnHeadersComponent } from '../../test-utils/grid-samples.spec';
import { configureTestSuite } from '../../test-utils/configure-suite';
import { GridFunctions } from '../../test-utils/grid-functions.spec';

describe('IgxGrid - Deferred Column Resizing #grid', () => {
configureTestSuite();
Expand Down Expand Up @@ -511,7 +512,7 @@ describe('IgxGrid - Deferred Column Resizing #grid', () => {
fixture.detectChanges();
const grid = fixture.componentInstance.grid;
const headers: DebugElement[] = fixture.debugElement.queryAll(By.css(COLUMN_HEADER_GROUP_CLASS));
const displayContainer: HTMLElement = fixture.componentInstance.grid.tbody.nativeElement.querySelector('igx-display-container');
const displayContainer: HTMLElement = GridFunctions.getGridDisplayContainer(fixture).nativeElement;
let rowsRendered = displayContainer.querySelectorAll('igx-display-container');
let colsRendered = rowsRendered[0].children;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -283,22 +283,22 @@ describe('IgxGrid - Filtering Row UI actions #grid', () => {
fix.detectChanges();
GridFunctions.verifyFilteringDropDownIsOpened(fix);

prefix.triggerEventHandler('keydown', UIInteractions.spaceEvent);
UIInteractions.triggerEventHandlerKeyDown(' ', prefix);
tick(30);
fix.detectChanges();
GridFunctions.verifyFilteringDropDownIsOpened(fix, false);

input.triggerEventHandler('keydown', UIInteractions.enterEvent);
UIInteractions.triggerEventHandlerKeyDown('Enter', input);
tick(30);
fix.detectChanges();
GridFunctions.verifyFilteringDropDownIsOpened(fix);

prefix.triggerEventHandler('keydown', UIInteractions.tabEvent);
UIInteractions.triggerEventHandlerKeyDown('Tab', prefix);
tick(30);
fix.detectChanges();
GridFunctions.verifyFilteringDropDownIsOpened(fix, false);

input.triggerEventHandler('keydown', UIInteractions.spaceEvent);
UIInteractions.triggerEventHandlerKeyDown(' ', input);
tick(30);
fix.detectChanges();
GridFunctions.verifyFilteringDropDownIsOpened(fix);
Expand Down Expand Up @@ -980,7 +980,7 @@ describe('IgxGrid - Filtering Row UI actions #grid', () => {
expect(filterChip.componentInstance.selected).toBeTruthy();
expect(input.componentInstance.value).toEqual('a');

input.triggerEventHandler('keydown', UIInteractions.enterEvent);
UIInteractions.triggerEventHandlerKeyDown('Enter', input);
fix.detectChanges();

// Check focus is kept and chips is no longer selected.
Expand Down Expand Up @@ -1298,8 +1298,7 @@ describe('IgxGrid - Filtering Row UI actions #grid', () => {

const filterUIRow = fix.debugElement.query(By.css(FILTER_UI_ROW));
const input = filterUIRow.query(By.directive(IgxInputDirective));

input.triggerEventHandler('keydown', UIInteractions.altAndArrowDownEvent);
UIInteractions.triggerEventHandlerKeyDown('ArrowDown', input, true);
tick(30);
fix.detectChanges();
GridFunctions.verifyFilteringDropDownIsOpened(fix);
Expand All @@ -1311,7 +1310,7 @@ describe('IgxGrid - Filtering Row UI actions #grid', () => {
let filterUIRow = fix.debugElement.query(By.css(FILTER_UI_ROW));
const input = filterUIRow.query(By.directive(IgxInputDirective));

input.triggerEventHandler('keydown', UIInteractions.escapeEvent);
UIInteractions.triggerEventHandlerKeyDown('Escape', input);
tick(100);
fix.detectChanges();

Expand Down Expand Up @@ -1348,7 +1347,7 @@ describe('IgxGrid - Filtering Row UI actions #grid', () => {
verifyFilterRowUI(input, close, reset, false);

// submit the input with empty value
input.triggerEventHandler('keydown', UIInteractions.enterEvent);
UIInteractions.triggerEventHandlerKeyDown('Enter', input);
tick(50);
fix.detectChanges();

Expand Down Expand Up @@ -1623,7 +1622,7 @@ describe('IgxGrid - Filtering Row UI actions #grid', () => {

// Press 'Enter' on the commit icon.
const inputCommitIcon = GridFunctions.getFilterRowInputCommitIcon(fix);
inputCommitIcon.triggerEventHandler('keydown', UIInteractions.enterEvent);
UIInteractions.triggerEventHandlerKeyDown('Enter', inputCommitIcon);
tick(200);
fix.detectChanges();

Expand All @@ -1645,7 +1644,7 @@ describe('IgxGrid - Filtering Row UI actions #grid', () => {

// Press 'Enter' on the clear icon.
const inputClearIcon = GridFunctions.getFilterRowInputClearIcon(fix);
inputClearIcon.triggerEventHandler('keydown', UIInteractions.enterEvent);
UIInteractions.triggerEventHandlerKeyDown('Enter', inputClearIcon);
tick(200);
fix.detectChanges();

Expand All @@ -1659,7 +1658,7 @@ describe('IgxGrid - Filtering Row UI actions #grid', () => {
expect(fix.debugElement.query(By.css(FILTER_UI_ROW))).toBeNull();

const filterCellChip = GridFunctions.getFilterChipsForColumn('ReleaseDate', fix)[0];
filterCellChip.triggerEventHandler('keydown', UIInteractions.enterEvent);
UIInteractions.triggerEventHandlerKeyDown('Enter', filterCellChip);
tick(200);
fix.detectChanges();

Expand Down
Loading