Skip to content

Action Strip Component #6984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 94 commits into from
Apr 29, 2020
Merged

Action Strip Component #6984

merged 94 commits into from
Apr 29, 2020
+1,750 −3

Conversation

dkamburov
Copy link
Contributor

@dkamburov dkamburov commented Mar 26, 2020 •
edited by desig9stein
Loading

Closes #6941, #7117

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@ChronosSF ChronosSF added action-strip 🛠️ status: in-development Issues and PRs with active development on them labels Mar 27, 2020
dkamburov and others added 21 commits April 2, 2020 09:15
@dkamburov
chore(*): Add POC for grid actions component
540ae50
@dkamburov
chore(grid-actions): Add POC for grid pinning actions
42534ba
@dkamburov
chore(grid-actions): Add POC for grid editing action
28f078f
@dkamburov
chore(*): Polish some samples
a568c75
@dkamburov
chore(action-stip): Fix pinning icon and add delete icon
24bad5e
@dkamburov
Merge branch 'master' into dkamburov/action-strip
b005dc7
@dkamburov
chore(action-strip): Fix build errors with imports

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
2af9d4e
@dkamburov
feat(action-strip): Implement isMenu option #6941

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
af4eaa5
@dkamburov
chore(action-strip): Remove grid actions component

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a4bae33
@ChronosSF
Merge branch 'master' into dkamburov/action-strip
ed2669f
@dkamburov
chore(grid-action): Overlap the container of action strip
02a503f
@dkamburov
chore(action-strip): Polish the dev samples on action strip
8668c40
@dkamburov
Merge branch 'master' into dkamburov/action-strip

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9487c4d
@ChronosSF
Merge branch 'master' into dkamburov/action-strip

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b3dd844
@ChronosSF
Merge branch 'master' into dkamburov/action-strip
62a7104
@dkamburov
Merge branch 'master' into dkamburov/action-strip
271dea5
@dkamburov
Merge branch 'master' into dkamburov/action-strip

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8580056
@ChronosSF
Merge branch 'master' into dkamburov/action-strip

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5aeb146
@ChronosSF
Merge branch 'master' into dkamburov/action-strip

Verified

This commit was signed with the committer’s verified signature.
earl-warren Earl Warren
GPG key ID: 0579CB2928A78A00
Verified
Learn about vigilant mode
6c5b9e0
@ChronosSF
Merge branch 'master' into dkamburov/action-strip
b386f04
@dkamburov
feat(action-strip): Implement IgxGridActionsBaseDirective #6941
2d11b18
@ChronosSF ChronosSF added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 28, 2020
@skrustev
Copy link
Member

skrustev commented Apr 28, 2020 •
edited by dkamburov
Loading

Issues currently found as well:

  • The context is not specified as an input according to spec and does not work as described:
    Context_input

  • The overlay is not visible when there are right pinned columns:
    AS_pinning_after

  • When scrolling using the vertical scrollbar and the menu gets out of view it positions itself to the top right of the screen.
    MenuScroll

MayaKirova
MayaKirova requested changes Apr 28, 2020
View reviewed changes
@MayaKirova MayaKirova self-requested a review April 29, 2020 11:44
@skrustev skrustev added version: 9.1.x ✅ status: verified Applies to PRs that have passed manual verification 💥 status: in-test PRs currently being tested and removed 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification labels Apr 29, 2020
@skrustev skrustev added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Apr 29, 2020
@ChronosSF ChronosSF merged commit 079f58d into master Apr 29, 2020
@ChronosSF ChronosSF deleted the dkamburov/action-strip branch April 29, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChronosSF ChronosSF

@kdinev kdinev

@StefanIvanov StefanIvanov

@simeonoff simeonoff

@damyanpetev damyanpetev

@MayaKirova MayaKirova

Assignees

@ChronosSF ChronosSF

@skrustev skrustev

Labels
action-strip version: 9.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Action Strip Styling Action Strip component
6 participants
@dkamburov @MayaKirova @ChronosSF @skrustev @damyanpetev @simeonoff