Houdini symbol visibility management #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucienfostier confirms tests also pass with H17.5.258 |
andrewkaufman
force-pushed
the
houdiniSymbols
branch
from
6b462d2 to
4c3b759
Compare
johnhaddon
reviewed
Jun 17, 2019
This is required now that we're compiling with -Werror
I'd rather relegate these to the bindings, but I don't have time to unwind ParameterisedHolder's use of them right now.
andrewkaufman
force-pushed
the
houdiniSymbols
branch
from
4c3b759 to
26177e0
Compare
|
I've squashed in the |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caries on from #695 applying symbol visibility to IECoreHoudini.
Along the way I (re)discovered that libIECoreHoudini has a python dependency, which isn't ideal, so I removed one of those and added todos for the rest.
I was hoping this would help me along on the issues I'm hitting in #954, but alas it did not. There is enough here that it seemed worth splitting out to its own PR, as the longer 07d552e lingers the harder it will be to merge.
Tests are passing in H17.0.416, @lucienfostier is going to verify in H17.5 as well.
Note: I don't really understand symbol visibility too deeply. I'm more or less following the pattern established in #695... but I have verified there are fewer public symbols in the resulting libIECoreHoudini.so and _IECoreHoudini.so (bindings), and I did hit a couple missing symbols that were needed along the way, so I'm fairly confident its working.