Skip to content

Conversation

sebcoetzee
Copy link
Contributor

@sebcoetzee sebcoetzee commented Jun 7, 2016

@dmke please look at this, this is causing an error when requiring the gem.

/Users/sebastiancoetzee/.rvm/gems/ruby-1.9.3-p545@insight-app/gems/activesupport-3.2.22.2/lib/active_support/dependencies.rb:251:in `require': /Users/sebastiancoetzee/.rvm/gems/ruby-1.9.3-p545@insight-app/gems/influxdb-0.3.3/lib/influxdb/query/continuous_query.rb:13: syntax error, unexpected tLABEL (SyntaxError)
...atabase, query, resample_every: nil, resample_for: nil)
...                               ^
/Users/sebastiancoetzee/.rvm/gems/ruby-1.9.3-p545@insight-app/gems/influxdb-0.3.3/lib/influxdb/query/continuous_query.rb:13: Can't assign to nil
...se, query, resample_every: nil, resample_for: nil)
...                               ^
/Users/sebastiancoetzee/.rvm/gems/ruby-1.9.3-p545@insight-app/gems/influxdb-0.3.3/lib/influxdb/query/continuous_query.rb:31: syntax error, unexpected keyword_end, expecting $end

@sebcoetzee sebcoetzee closed this Jun 7, 2016
@sebcoetzee
Copy link
Contributor Author

@dmke Pardon, I see now that this is a Ruby < 2 issue with keyword arguments.

@dmke
Copy link
Contributor

dmke commented Jun 7, 2016

Indeed, support for Ruby < 2.0 was dropped with v0.2.0.

@dmke
Copy link
Contributor

dmke commented Jun 7, 2016

Would you mind amend your PR to use an options={} argument, so that the tests continue to work?

Since there are now a few 1.9 requests within a few days, I'm reconsidering 1.9 support.

@dmke dmke reopened this Jun 7, 2016
@dmke dmke added the ruby-1.9 label Jun 7, 2016
@dmke dmke mentioned this pull request Jun 7, 2016
@sebcoetzee sebcoetzee changed the title Fix SyntaxError in v0.3.3 create_continuous_query method Fix create_continuous_query method for Ruby 1.9 compatibility Jun 7, 2016
@dmke dmke merged commit b213053 into InfluxCommunity:master Jun 7, 2016
@sebcoetzee
Copy link
Contributor Author

Thanks for the quick response @dmke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants