Skip to content

feat: create Client from connection string or environment variables #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 27, 2023

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Sep 1, 2023

Closes #

Proposed Changes

This PR adds support to create Client from

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b26e715) 98.84% compared to head (66100b7) 98.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   98.84%   98.90%   +0.05%     
==========================================
  Files          12       12              
  Lines         955     1007      +52     
==========================================
+ Hits          944      996      +52     
  Misses         11       11              
Files Coverage Δ
Client/Config/ClientConfig.cs 100.00% <100.00%> (ø)
Client/Config/WriteOptions.cs 100.00% <100.00%> (ø)
Client/InfluxDBClient.cs 94.76% <100.00%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alespour alespour marked this pull request as ready for review September 1, 2023 17:42
@bednar bednar added this to the 0.3.0 milestone Sep 27, 2023
@bednar bednar merged commit 50bf3b6 into main Sep 27, 2023
@bednar bednar deleted the feat/init-from-connection-string-or-env branch September 27, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants