fix: add ut for backend runtime. #428
Conversation
InftyAI-Agent
added
needs-triage
|
/kind cleanup |
InftyAI-Agent
added
cleanup
|
Would you like to take a view first @googs1025 |
|
/cc sure. I'll take a look today 😄 |
| resourcesNil bool | ||
| shmNil bool |
There was a problem hiding this comment.
Can we not only check whether it is nil, but also check whether it is exactly the same?
There was a problem hiding this comment.
Make sense, I have changed to real variable.
| type want struct { | ||
| cmd []string | ||
| envs []corev1.EnvVar | ||
| lifecycle *corev1.Lifecycle |
| }, | ||
| } | ||
|
|
||
| return &BackendRuntimeParser{ |
There was a problem hiding this comment.
can we use NewBackendRuntimeParser ?
There was a problem hiding this comment.
Make sense, I will fix it with NewBackendRuntimeParser function.
|
|
||
| return &BackendRuntimeParser{ | ||
| backendRuntime: backend, | ||
| models: []*coreapi.OpenModel{{}}, // 这里只需要占位 |
There was a problem hiding this comment.
remove chinese, and can we add OpenModel for test?
| p := tc.parser | ||
|
|
||
| if diff := cmp.Diff(tc.want.cmd, p.Command()); diff != "" { | ||
| t.Fatalf("Command() mismatch (-want +got):\n%s", diff) |
There was a problem hiding this comment.
Can we keep the error information consistent across each output?
example:
t.Fatalf("Command() mismatch (-want +got):\n%s", diff)
t.Fatalf("Image() = %s, want %s", got, tc.want.image)
There was a problem hiding this comment.
Thank you, I will change them to same output.
|
/approve Leave the LGTM to @googs1025 |
InftyAI-Agent
added
the
approved
|
|
||
| return &BackendRuntimeParser{ | ||
| backendRuntime: backend, | ||
| models: []*coreapi.OpenModel{{}}, // 这里只需要占位 |
|
kindly ping @X1aoZEOuO |
What this PR does / why we need it
Add mode unit tests for backend runtime.
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
From:
To:
cc @kerthcet
Does this PR introduce a user-facing change?