feat: support react native buttons label extraction in user steps #1109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdelhamid-f-nasser
force-pushed
the
feat/support-user-steps
branch
2 times, most recently
from
6a576c7 to
1a03fd4
Compare
7 tasks
abdelhamid-f-nasser
force-pushed
the
feat/support-user-steps
branch
from
de201a4 to
d508b1c
Compare
a7medev
requested changes
Jan 29, 2024
There was a problem hiding this comment.
Good job @abdelhamid-f-nasser! 👏🏼
Please check the comments added. Let's also make sure to use ReactViewGroup and ReactTextView instead of ViewGroup and TextView when appropriate.
examples/default/src/screens/user-steps/BasicComponentsScreen.tsx
Outdated
Show resolved
Hide resolved
examples/default/src/screens/user-steps/BasicComponentsScreen.tsx
Outdated
Show resolved
Hide resolved
examples/default/src/screens/user-steps/BasicComponentsScreen.tsx
Outdated
Show resolved
Hide resolved
examples/default/src/screens/user-steps/BasicComponentsScreen.tsx
Outdated
Show resolved
Hide resolved
examples/default/src/screens/user-steps/BasicComponentsScreen.tsx
Outdated
Show resolved
Hide resolved
android/src/main/java/com/instabug/reactlibrary/utils/RNTouchedViewExtractor.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/instabug/reactlibrary/utils/RNTouchedViewExtractor.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/instabug/reactlibrary/utils/RNTouchedViewExtractor.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/instabug/reactlibrary/utils/RNTouchedViewExtractor.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/instabug/reactlibrary/utils/RNTouchedViewExtractor.java
Outdated
Show resolved
Hide resolved
abdelhamid-f-nasser
force-pushed
the
feat/support-user-steps
branch
from
ebcb19b to
ac3207a
Compare
abdelhamid-f-nasser
force-pushed
the
feat/support-user-steps
branch
2 times, most recently
from
9b93170 to
b365a44
Compare
|
I've pushed changes to implement the PrivateViews label extraction, please check them @a7medev 🙏 . |
a7medev
reviewed
Feb 5, 2024
android/src/main/java/com/instabug/reactlibrary/utils/RNTouchedViewExtractor.java
Outdated
Show resolved
Hide resolved
ahmedAlaaInstabug
approved these changes
Feb 6, 2024
Support extracting the label of the button in repro-steps via TouchedViewExtractor
Added buttons for testing purposes.
1. Remove redundant View component 2. Add missing textInputRef applying masking to it. 3. Adjust onPress messages for buttons 4. Rename `Add private views` to `Mask All Views` 5. Move refs declaration to the beginning of the component
1. Document `getShouldDependOnNative` 2. Change all references of Native Views to React Views (TextView and ViewGroup -> ReactTextView and ReactViewGroup) 3. Rename `iteratorIndex` to `depth` 4. Refactor the limit to a constant `depthTraversalLimit` 5. Start the loop with 1 and end at `depthTraversalLimit` 6. Add comment describing why we return null in the `extract` method
Jira ID: [IBGCRASH-21213]
Change the `A` to lowercase to become `a button` instead of `A button` Jira ID: [IBGCRASH-21213]
Add one more Tier between the 1st Tier Text and the 4th tier text (as you click on the text itself, so there has to be enough tiers between them).
abdelhamid-f-nasser
force-pushed
the
feat/support-user-steps
branch
from
e0e157b to
aa65b2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Support Capturing the label of buttons for repro-steps via adding custom implementation for the Touched View Extractor.
Type of change
Related issues
Jira ID:
Checklists
Development
Code review