SyclPlatform equality testing and hashing implemented #1333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing
dpctl
in the flat device hierarchy mode I realized we have not implemented equality testing fordpctl.SyclPlatform
which caused testtest_sycl_context.py::test_multi_device_different_platforms
to fail.This PR implements
DPCTLPlatform_AreEq
,DPCTLPlatform_Hash
, adds tests and implamentsdpctl.SyclPlatform.__equal__
anddpctl.SyclPlatform.__hash__
based on these.Incidentally this PR also corrects declaration of
DPCTLContext_Hash
which mistakenly used__dpctl_take
instead of__dpctl_keep
annotation.