Skip to content

Correct a path to cl.cfg file #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Correct a path to cl.cfg file #2068

merged 1 commit into from
Apr 30, 2025

Conversation

antonwolfy
Copy link
Collaborator

@antonwolfy antonwolfy commented Apr 30, 2025

The location of cl.cfg file created by installing intel-opencl-rt conda package has been changed few releases back from %CONDA_PREFIX%\Library\lib\cl.cfg to %CONDA_PREFIX%\Library\bin\cl.cfg.
The file is still created at Library\lib\cl.cfg path by intel-opencl-rt-post-link.bat script but with empty content.

The PR updates public CI to rely on correct path towards cl.cfg configuration file.
The issue with intel-opencl-rt-post-link.bat script has to be updated by a separate PR in the compiler repo.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@antonwolfy
Copy link
Collaborator Author

The workflow with nightly tests run is passed:
https://github.com/IntelPython/dpctl/actions/runs/14754790191

Copy link

github-actions bot commented Apr 30, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_173 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 86.419%. remained the same
when pulling c8700ce on update-path-to-cl.cfg
into b7a6b67 on master.

@ndgrigorian
Copy link
Collaborator

@antonwolfy
Tests pass so it's probably fine, but I'm surprised we never saw the same warnings in dpctl as dpnp, do you know why?

@antonwolfy
Copy link
Collaborator Author

In dpnp we removed the separate step with installing intel-opencl-rt package some time ago.
As I can identified, the issue in dpnp was only visible then during post link stage, there is some error occurred, like here:

Linking intel-opencl-rt-2025.1.0-intel_972
The process cannot access the file because it is being used by another process.
The system cannot find the file C:\Users\RUNNER~1\AppData\Local\Temp\__conda_tmp_17737.txt.
Failed to run 'conda activate "C:\\Users\\runneradmin\\miniconda3\\envs\\test"'.
C:\Users\RUNNER~1\AppData\Local\Temp\__conda_tmp_17737.txt

It's hard to say what exactly was going wrong there, but the script logic looks faulty in any case, because it creates an empty config:

setlocal EnableDelayedExpansion
set "cl_cfg_orig=%PREFIX%\Library\lib\cl.cfg"
set "cl_cfg_temp=%PREFIX%\Library\lib\cl.cfg.temp"
set "lib_bin=%PREFIX%\Library\bin"
set "PATH=%PATH%;C:\Windows\System32"
%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell -Command "(gc '%cl_cfg_orig%') -replace 'CL_CONFIG_TBB_DLL_PATH =.*', 'CL_CONFIG_TBB_DLL_PATH = %lib_bin%' | Out-File -Encoding ASCII -FilePath '%cl_cfg_temp%'"
move /Y "%cl_cfg_temp%" "%cl_cfg_orig%"

because there is no Library\lib\cl.cfg file.

In any case the cl.cfg is located at bin folder and it makes sense to rely on it there.

@ndgrigorian ndgrigorian merged commit 29eeac7 into master Apr 30, 2025
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants