Skip to content

Add types of emits #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Add types of emits #1

merged 3 commits into from
Sep 27, 2023

Conversation

kingyue737
Copy link
Contributor

Description

As some upstream type bugs vuejs/language-tools#1855 have been resolved, now we can have intellisense of events in SFC templates.

image

image

Not fully tested as I only use a small subset of all vuetify component events in my projects. Help wanted XD

Ensure that your pull request has followed all the steps below:

  • Code compilation
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@ascott18
Copy link
Contributor

Awesome - thank you!

@ascott18 ascott18 merged commit d78f91e into IntelliTect:main Sep 27, 2023
@kingyue737 kingyue737 deleted the event-types branch September 28, 2023 00:23
@johuhype
Copy link

Could you please have a look at v-calendar. At least the events for @change, @click:event, @click:date, @click:more are not getting processed correctly, altough they seem to be defined correctly on the documentation page.

e.g.
Type '(range: { start: CalendarTimestamp; end: CalendarTimestamp; }) => void' is not assignable to type '(...args: unknown[]) => void'.
Types of parameters 'range' and 'args' are incompatible.ts(2322)
(property) 'change': ((...args: unknown[]) => void) | undefined

@kingyue737
Copy link
Contributor Author

@johuhype sorry I wasn't notified as I unsubscribed this PR after closed, I will check this issue this week

@kingyue737
Copy link
Contributor Author

seems to be an upstream bug vuejs/language-tools#3719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants