Use COPYCHARS instead of COPYBYTES when HPRINT is copying from NODIRCORE buffer

[masinter]

I couldn't figure out how to set the NODIRCORE file's :FORMAT or end-of-line convention (or rather, get the current output stream values).

Note SPECIAL declaration needed but missing? Might be a problem when recompiling other files.

Note filetype is CL:COMPILE-FILE which it seems to use but produces an LCOM.

Finally it is still the case that (HPRINT DEFAULTFONT) fails to print an arrayblock, but that is (or will be) a separate issue.
#483

[rmkaplan]

With respect to format, you should open the nodircore stream with the format of the destination file. That should be a parameter `((FORMAT , (STREAMPROP destinationstream ‘FORMAT)). If that doesn’t work, well, something else is not as expected. But then, you don’t want to close the nodircore and open it again, because the format is not stored in such a file (it doesn’t have a define-file-info). You would happen to open it for input with the same format specification. Or, better would be to open the file ‘BOTH ‘NEW and set the fileptr back to 0. Is the SPECIAL with respect to *STANDARD-OUTPUT*, whether that is globally declared as special someplace? Otherwise, presumably has to be declared here? Note that we have a general legacy confusion now about whether parameter-names for Interlisp functions are in the keyword package, in the Interlisp package as is the legacy case, or in both as a transition to a keyword end-state. I used the legacy IL for STREAMPROP.

…

On Sep 28, 2021, at 11:21 AM, Larry Masinter ***@***.***> wrote: I couldn't figure out how to set the NODIRCORE file's :FORMAT or end-of-line convention (or rather, get the current output stream values). Note SPECIAL declaration needed but missing? Might be a problem when recompiling other files. Note filetype is CL:COMPILE-FILE which it seems to use but produces an LCOM. Finally it is still the case that (HPRINT DEFAULTFONT) fails to print an arrayblock, but that is (or will be) a separate issue. #483 <#483> You can view, comment on, or merge this pull request online at: #506 <#506> Commit Summary Use COPYCHARS instead of COPYBYTES when HPRINT is copying from NODIRCORE buffer <6a007c9> File Changes M sources/HPRINT <https://github.com/Interlisp/medley/pull/506/files#diff-4ba736356f88ba187bae416354731b28c1b620dedebfdf409327d86a2548fdb4> (58) M sources/HPRINT.LCOM <https://github.com/Interlisp/medley/pull/506/files#diff-b8e6afdba5eaa55c63be0a8118bc956f7ead73f57a883d53aa3267518e9f9e44> (0) Patch Links: https://github.com/Interlisp/medley/pull/506.patch <https://github.com/Interlisp/medley/pull/506.patch> https://github.com/Interlisp/medley/pull/506.diff <https://github.com/Interlisp/medley/pull/506.diff> — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#506>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJP7M7ITANM5OC4PIPDUEIBT7ANCNFSM5E6BHJJA>.

[masinter]

i changed HPRINT to use :FORMAT of standard output in NODIRCORE file; should it delete it?
The problem with raw arrayblocks remains -- will open separate issue.

[rmkaplan]

A little simpler would be to set the fileptr to 0 before the copychars, and then leave out both START and END. That will also get the whole file.

[rmkaplan]

You shouldn’t have to delete NODIRCORE, if you don’t hold onto it, it will get collected.

…

On Oct 17, 2021, at 2:08 PM, Larry Masinter ***@***.***> wrote: i changed HPRINT to use :FORMAT of standard output in NODIRCORE file; should it delete it? The problem with raw arrayblocks remains -- will open separate issue. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#506 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJMDWXOLZWJJKA2GLSDUHM3OHANCNFSM5E6BHJJA>.